[MLAS] Avoid default parameters in MLAS function signatures - #27128
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes default parameter values from three MLAS function signatures in the header file mlas.h to align with MLAS coding conventions.
Changes:
- Removed default parameter values from MLAS function signatures to maintain consistency with MLAS library conventions
- Updated function declarations to require explicit parameter passing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hariharans29
changed the title
tianleiwu
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IIUC, the MLAS functionsignatures in the mlas header shouldn't use default parameters. Removing them in a couple of places.