Fix CPU ReverseSequence returning zeros for zero-length sequences#28759
Merged
Conversation
…crosoft#28490) Remove the early continue for seq_len == 0; the output isn't pre-copied, so the pass-through loop must run to leave the column unchanged. Add a regression test.
xadupre
approved these changes
Jun 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an incorrect CPU ReverseSequence result when a batch’s sequence_lens[i] == 0, where the output column was previously left uninitialized (observed as zeros) instead of matching the input. The fix removes the early continue so the existing [seq_len, max_seq_len) copy loop runs and preserves the unchanged portion as required by the operator semantics.
Changes:
- Remove the
seq_len == 0early-continuein the CPUReverseSequenceImplso the “copy-through” loop executes for zero-length sequences. - Add a regression unit test covering
sequence_lenscontaining a zero (ReverseSequenceTest.ZeroSequenceLength).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
onnxruntime/core/providers/cpu/tensor/reverse_sequence.cc |
Removes the seq_len == 0 early exit so zero-length batches are copied through instead of leaving output uninitialized. |
onnxruntime/test/providers/cpu/tensor/reverse_sequence_test.cc |
Adds a regression test validating that a zero sequence length leaves the corresponding batch column unchanged. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ReverseSequenceImplskips a batch withcontinuewhenseq_len == 0, but the output isn't pre-copied from the input, so that column is left as zeros instead of unchanged. Removing the earlycontinuelets the existing[seq_len, max_seq_len)loop copy the whole column through.Adds
ReverseSequenceTest.ZeroSequenceLength.Motivation and Context
Fixes #28490. Labelled
[OpenVINO]but the bug is in the CPU EP.