Remove the dynamic WGSL generator (duktape/Node) path#29141
Merged
guschmue merged 1 commit intoJun 22, 2026
Conversation
danielsongmicrosoft
marked this pull request as ready for review
June 17, 2026 19:28
Contributor
|
It is still referenced in |
guschmue
approved these changes
Jun 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the remaining dead code and dependency declarations for the deprecated dynamic WGSL template generator (duktape/Node-based), leaving the static Python-generated WGSL path as the only supported mechanism in the WebGPU EP.
Changes:
- Deletes the unreachable
ORT_WGSL_TEMPLATE_DYNAMICbranch fromwgsl_gen.h/wgsl_gen.cc. - Removes the unused duktape dependency plumbing from CMake external deps and the pinned deps list.
- Drops the vcpkg feature/override entries that existed solely to support the removed dynamic generator.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| onnxruntime/core/providers/webgpu/wgsl_templates/wgsl_gen.h | Removes the dynamic-generator macro/API branch; header now only exposes the static template macros and generated index includes. |
| onnxruntime/core/providers/webgpu/wgsl_templates/wgsl_gen.cc | Deletes the duktape-based implementation and associated includes/comments; keeps only the static generated implementation include. |
| cmake/vcpkg.json | Removes the webgpu-ep-wgsl-template-dynamic feature and the duktape override. |
| cmake/external/onnxruntime_external_deps.cmake | Removes the dead duktape FetchContent/vcpkg block gated on the old dynamic WGSL template mode. |
| cmake/deps.txt | Removes the pinned duktape URL/hash entry that is no longer referenced anywhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The static Python WGSL generator (tools/python/wgsl_gen.py) is now the only
supported mode. The dynamic generator was removed from the build surface, but
its code and dependency declarations were left in tree. This change now deletes the unreachable
remnants.
Motivation and Context
This code is unreachable and unused.
Tracking issue: #28826