Add int32 support for CPU Trilu#29476
Open
the0cp wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Hi @skottmckay, sorry for the gentle ping, would you be the right person to review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add INT32 input support for the CPU implementation of ONNX
Trilu.The ONNX
Triluschema allowstensor(int32), and CUDA EP already supports it, but CPU EP currently does not register an INT32 kernel and fails during session creation withNOT_IMPLEMENTED.int32_tto the CPU ONNXTrilu(14)kernel registrationMotivation and Context
The CPU
Triluimplementation previously dispatched based on element size. That works only as long as each supported element size maps to a single supported logical type. Adding INT32 would otherwise make it share thefloatpath because both are 4-byte types.The old size-based dispatch is ambiguous for types with the same element size, such as
float/int32anddouble/int64. This PR switches dispatch to the actual ONNX tensor element type so each registered type maps to the matchingTriluImpl<T>specialization.Fixes #21400.