Use int64 loop counters in CPU Compress - #32008
Merged
Akshay Sonawane (apsonawane) merged 2 commits intoAug 13, 2026
Merged
Conversation
Akshay Sonawane (apsonawane)
enabled auto-merge (squash)
August 12, 2026 05:32
Copilot started reviewing on behalf of
Akshay Sonawane (apsonawane)
August 12, 2026 05:32
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates loop counter types in the CPU Compress::Compute implementation to use int64_t instead of int, aligning iteration types with tensor shape/count types to better support large tensors.
Changes:
- Switched multiple
for-loop indices inCompress::Computefrominttoint64_tto avoidintoverflow on large shapes. - Updated nested loops in the axis-handling path (including the inner element loop) to iterate with
int64_t.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ti-Tai Wang (titaiwangms)
approved these changes
Aug 13, 2026
Akshay Sonawane (apsonawane)
deleted the
fix/compress-int64-loop-counters
branch
August 13, 2026 17:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates several for-loop variable types in the
Compress::Computemethod to useint64_tinstead ofint. This improves consistency and prevents potential issues when handling large tensors with dimensions exceeding the range ofint.Type consistency and correctness:
inttoint64_tin all relevant for-loops withinCompress::Computeto ensure proper handling of large tensor sizes and avoid integer overflow. [1] [2] [3] [4]