Merged
Conversation
…o ryanunderhill/mkldnn_dll
…o ryanunderhill/mkldnn_dll
…o ryanunderhill/mkldnn_dll
…o ryanunderhill/mkldnn_dll
…o ryanunderhill/mkldnn_dll
…o ryanunderhill/mkldnn_dll
…o ryanunderhill/mkldnn_dll
Nodearg, Node, GraphViewer Gets as far as GraphViewer::GetAllInitializedTensors before hitting not implemented code.
Now gets up to calling void IndexedSubGraph::SetMetaDef(std::unique_ptr<MetaDef>& meta_def_)
skottmckay
reviewed
May 5, 2020
skottmckay
reviewed
May 5, 2020
skottmckay
reviewed
May 5, 2020
skottmckay
reviewed
May 5, 2020
pranavsharma
reviewed
May 5, 2020
pranavsharma
reviewed
May 5, 2020
Member
|
are there any changes related to packaging the shared lib in the python package? |
jywu-msft
reviewed
May 5, 2020
onnxruntime/core/providers/shared_library/provider_interfaces.h
Outdated
Show resolved
Hide resolved
jywu-msft
reviewed
May 5, 2020
jywu-msft
reviewed
May 5, 2020
…o ryanunderhill/mkldnn_dll
snnn
reviewed
May 6, 2020
pranavsharma
approved these changes
May 6, 2020
Contributor
pranavsharma
left a comment
pranavsharma
left a comment
There was a problem hiding this comment.
Let's ensure there's a task created to address the TODOs in this PR. Thanks!
Member
did you get a change to build and test a python package built with dnnl ep shared lib? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partway progress to making DNNL work as a DLL vs being tightly integrated.
What works so far:
Loads provider as a DLL
Sets up the allocators
Registers the KernelDefs