Ignore invalid input argument to install_os_deps.sh#7566
Merged
Conversation
Contributor
|
Btw, I have #7568 to fix the compiler warnings-as-errors in gist_encode_decode.cc. |
baijumeswani
force-pushed
the
bmeswani/ignore_invaid_options
branch
from
May 5, 2021 18:57
c27aa3a to
2b335b6
Compare
snnn
approved these changes
May 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: The arguments to
install_os_deps.shwere trimmed but the script invoking this script was still passing those unused arguments.As a result,
getoptswas exiting the loop without parsing all the valid arguments. This resulted in some of the dependencies not being installed (likeopenmpi) and caused theorttraining-distributedpipeline failure.