Reduce max gradient by anhnguyen7198 · Pull Request #9859 · microsoft/onnxruntime

anhnguyen7198 · 2021-11-24T18:24:26Z

Description: Add ReduceMax gradient implementation.

Motivation and Context

Export torch.max operation to ONNX and build backward graph using ORTModule need ReduceMax gradient implementation

ghost · 2021-11-24T18:24:38Z

All CLA requirements met.

esaliya · 2021-12-08T23:10:26Z

@Aayush-Ankit or @souptc could you trigger the CI pipelines for this?

Aayush-Ankit · 2021-12-09T17:22:37Z

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, onnxruntime-python-checks-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed

azure-pipelines · 2021-12-09T17:22:45Z

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

Aayush-Ankit · 2021-12-09T17:24:13Z

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline

azure-pipelines · 2021-12-09T17:24:38Z

Azure Pipelines successfully started running 4 pipeline(s).

Aayush-Ankit · 2021-12-09T17:26:13Z

/azp run Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline

azure-pipelines · 2021-12-09T17:27:00Z

Azure Pipelines successfully started running 7 pipeline(s).

Aayush-Ankit · 2021-12-09T17:28:02Z

/azp run onnxruntime-python-checks-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed

azure-pipelines · 2021-12-09T17:28:27Z

Azure Pipelines successfully started running 4 pipeline(s).

Aayush-Ankit · 2021-12-15T21:54:09Z

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline

azure-pipelines · 2021-12-15T21:54:33Z

Azure Pipelines successfully started running 4 pipeline(s).

Aayush-Ankit · 2021-12-15T21:56:43Z

/azp run Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline

azure-pipelines · 2021-12-15T21:57:19Z

Azure Pipelines successfully started running 7 pipeline(s).

Aayush-Ankit · 2021-12-15T21:57:42Z

/azp run onnxruntime-python-checks-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed

azure-pipelines · 2021-12-15T21:58:27Z

Azure Pipelines successfully started running 4 pipeline(s).

Aayush-Ankit · 2022-02-10T17:59:49Z

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline

azure-pipelines · 2022-02-10T18:00:17Z

Azure Pipelines successfully started running 4 pipeline(s).

Aayush-Ankit · 2022-02-10T18:00:34Z

/azp run Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline

azure-pipelines · 2022-02-10T18:01:21Z

Azure Pipelines successfully started running 7 pipeline(s).

Aayush-Ankit · 2022-02-14T23:30:56Z

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline

Aayush-Ankit · 2022-02-14T23:31:08Z

/azp run Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline

azure-pipelines · 2022-02-14T23:31:22Z

Azure Pipelines successfully started running 4 pipeline(s).

azure-pipelines · 2022-02-14T23:31:44Z

Azure Pipelines successfully started running 7 pipeline(s).

…8/onnxruntime into reduce-max-gradient

Aayush-Ankit · 2022-02-15T16:27:02Z

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline

Aayush-Ankit · 2022-02-15T16:27:17Z

/azp run Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline

azure-pipelines · 2022-02-15T16:27:29Z

Azure Pipelines successfully started running 4 pipeline(s).

azure-pipelines · 2022-02-15T16:27:57Z

Azure Pipelines successfully started running 7 pipeline(s).

souptc · 2022-02-15T19:07:11Z

/azp run onnxruntime-binary-size-checks-ci-pipeline onnxruntime-python-checks-ci-pipeline orttraining-linux-ci-pipeline orttraining-linux-gpu-ci-pipeline orttraining-ortmodule-distributed

azure-pipelines · 2022-02-15T19:07:17Z

No pipelines are associated with this pull request.

souptc · 2022-02-15T19:09:20Z

/azp run Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-python-checks-ci-pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed

azure-pipelines · 2022-02-15T19:09:55Z

Azure Pipelines successfully started running 7 pipeline(s).

souptc · 2022-02-15T23:13:12Z

/azp run orttraining-amd-gpu-ci-pipeline,onnxruntime-binary-size-checks-ci-pipeline

azure-pipelines · 2022-02-15T23:13:26Z

Azure Pipelines successfully started running 2 pipeline(s).

ytaous · 2022-02-16T18:35:09Z

Hi, this PR is failing AMD CI - can you pls revert it to mitigate it for now?

https://dev.azure.com/onnxruntime/onnxruntime/_build?definitionId=130&_a=summary

This reverts commit 7443edb.

anhnguyen7198 added 2 commits November 24, 2021 10:20

ReduceMax gradient builder

e93f8a0

Update gradient_builder.cc

f04c9e9

Aayush-Ankit closed this Dec 9, 2021

Aayush-Ankit reopened this Dec 9, 2021

souptc previously approved these changes Dec 14, 2021

View reviewed changes

Merge branch 'microsoft:master' into reduce-max-gradient

86ed6a2

Add CI fix

e30c94f

anhnguyen7198 dismissed souptc’s stale review via e30c94f February 14, 2022 20:08

Anonymous7198 and others added 2 commits February 14, 2022 12:28

Remove whitepace

fc2523d

Update gradient_builder.cc

7e221f6

Update gradient_ops_test.cc

15bbd7b

souptc previously approved these changes Feb 14, 2022

View reviewed changes

Anonymous7198 added 2 commits February 14, 2022 20:09

Fix Window CI tests

92c7278

Merge branch 'reduce-max-gradient' of https://github.com/anhnguyen719…

acd54ed

…8/onnxruntime into reduce-max-gradient

anhnguyen7198 dismissed souptc’s stale review via acd54ed February 15, 2022 04:10

souptc approved these changes Feb 16, 2022

View reviewed changes

souptc merged commit 7443edb into microsoft:master Feb 16, 2022

ytaous added a commit that referenced this pull request Feb 16, 2022

Revert "Reduce max gradient (#9859)"

53103eb

This reverts commit 7443edb.

This was referenced Feb 16, 2022

Revert "Reduce max gradient" #10572

Closed

Revert "Reduce max gradient" #10574

Merged

ytaous added a commit that referenced this pull request Feb 17, 2022

Revert "Reduce max gradient (#9859)" (#10574)

4f76c38

This reverts commit 7443edb.

Uh oh!

Conversation

anhnguyen7198 commented Nov 24, 2021

Uh oh!

ghost commented Nov 24, 2021 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

esaliya commented Dec 8, 2021

Uh oh!

Aayush-Ankit commented Dec 9, 2021

Uh oh!

azure-pipelines Bot commented Dec 9, 2021

Uh oh!

Aayush-Ankit commented Dec 9, 2021

Uh oh!

azure-pipelines Bot commented Dec 9, 2021

Uh oh!

Aayush-Ankit commented Dec 9, 2021

Uh oh!

azure-pipelines Bot commented Dec 9, 2021

Uh oh!

Aayush-Ankit commented Dec 9, 2021

Uh oh!

azure-pipelines Bot commented Dec 9, 2021

Uh oh!

Aayush-Ankit commented Dec 15, 2021

Uh oh!

azure-pipelines Bot commented Dec 15, 2021

Uh oh!

Aayush-Ankit commented Dec 15, 2021

Uh oh!

azure-pipelines Bot commented Dec 15, 2021

Uh oh!

Aayush-Ankit commented Dec 15, 2021

Uh oh!

azure-pipelines Bot commented Dec 15, 2021

Uh oh!

Aayush-Ankit commented Feb 10, 2022

Uh oh!

azure-pipelines Bot commented Feb 10, 2022

Uh oh!

Aayush-Ankit commented Feb 10, 2022

Uh oh!

azure-pipelines Bot commented Feb 10, 2022

Uh oh!

Aayush-Ankit commented Feb 14, 2022

Uh oh!

Aayush-Ankit commented Feb 14, 2022

Uh oh!

azure-pipelines Bot commented Feb 14, 2022

Uh oh!

azure-pipelines Bot commented Feb 14, 2022

Uh oh!

Aayush-Ankit commented Feb 15, 2022

Uh oh!

Aayush-Ankit commented Feb 15, 2022

Uh oh!

azure-pipelines Bot commented Feb 15, 2022

Uh oh!

azure-pipelines Bot commented Feb 15, 2022

Uh oh!

souptc commented Feb 15, 2022

Uh oh!

azure-pipelines Bot commented Feb 15, 2022

Uh oh!

souptc commented Feb 15, 2022

Uh oh!

azure-pipelines Bot commented Feb 15, 2022

Uh oh!

souptc commented Feb 15, 2022

Uh oh!

azure-pipelines Bot commented Feb 15, 2022

Uh oh!

ytaous commented Feb 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

ghost commented Nov 24, 2021 •

edited by ghost

Loading

ytaous commented Feb 16, 2022 •

edited

Loading