Fix build warnings with VS 2022 - #9967
Merged
Merged
Conversation
snnn (snnn)
reviewed
Dec 8, 2021
| #pragma warning(disable: 4189) | ||
| const int r = WideCharToMultiByte(CP_ACP, 0, s.data(), src_len, (char*)ret.data(), len, nullptr, nullptr); | ||
| assert(len == r); | ||
| #pragma warning(default: 4189) |
Contributor
There was a problem hiding this comment.
Because r is not referenced in release mode?
Contributor
Author
There was a problem hiding this comment.
Correct.
snnn (snnn)
approved these changes
Dec 8, 2021
Peter Salas (petersalas)
pushed a commit
to octoml/onnxruntime
that referenced
this pull request
Nov 8, 2022
(cherry picked from commit 051d005)
Peter Salas (petersalas)
pushed a commit
to octoml/onnxruntime
that referenced
this pull request
Nov 8, 2022
(cherry picked from commit 051d005)
Peter Salas (petersalas)
pushed a commit
to octoml/onnxruntime
that referenced
this pull request
Nov 8, 2022
(cherry picked from commit 051d005)
Peter Salas (petersalas)
pushed a commit
to octoml/onnxruntime
that referenced
this pull request
Nov 8, 2022
(cherry picked from commit 051d005)
Peter Salas (petersalas)
pushed a commit
to octoml/onnxruntime
that referenced
this pull request
Nov 8, 2022
(cherry picked from commit 051d005)
Peter Salas (petersalas)
pushed a commit
to octoml/onnxruntime
that referenced
this pull request
Nov 8, 2022
(cherry picked from commit 051d005)
Peter Salas (petersalas)
pushed a commit
to octoml/onnxruntime
that referenced
this pull request
Nov 8, 2022
(cherry picked from commit 051d005)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build warnings stop build with VS 2022 in helper.cc.