This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Change ID-format, resultCode, Success for tracing #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
reviewed
Dec 26, 2019
| span.context.span_id | ||
| ), | ||
| resultCode="0", # TODO | ||
| resultCode="0", |
Contributor
Author
There was a problem hiding this comment.
Do you mean to use the "StatusCanonicalCode"?
lmolkova
reviewed
Dec 26, 2019
| span.context.span_id | ||
| ), | ||
| duration=utils.ns_to_duration(span.end_time - span.start_time), | ||
| responseCode="0", |
lmolkova
reviewed
Dec 27, 2019
| ), | ||
| duration=utils.ns_to_duration(span.end_time - span.start_time), | ||
| responseCode="0", | ||
| responseCode=str(StatusCanonicalCode.OK.value), |
There was a problem hiding this comment.
I mean we have a real status of the span, can we use that one?
Contributor
Author
There was a problem hiding this comment.
I was trying to keep the old behaviour, but since there were a bunch of TODOs it's safe to assume that we want to change this. I will change it to use the status of the span.
lmolkova
approved these changes
Dec 28, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #21, and #22
@lmolkova