Skip to content

Add dependency conflict check for httpx and httpx2 since there are two entry points - #259

Merged
Radhika Gupta (rads-1996) merged 4 commits into
microsoft:mainfrom
rads-1996:add-dep-conflicts-check
Sep 4, 2026
Merged

Add dependency conflict check for httpx and httpx2 since there are two entry points#259
Radhika Gupta (rads-1996) merged 4 commits into
microsoft:mainfrom
rads-1996:add-dep-conflicts-check

Conversation

@rads-1996

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new changelog entry is missing the consistent PR reference/link formatting used elsewhere in the file.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR adds per-entry-point dependency conflict detection for the httpx and httpx2 OpenTelemetry instrumentations so that a dependency issue in one entry point does not prevent the other from being enabled.

Changes:

  • Add an httpx/httpx2-specific dependency conflict check in _setup_instrumentations() before instrumenting each entry point.
  • Add tests to validate that dependency conflicts skip only the affected entry point and that non-httpx instrumentations do not run the new check.
  • Document the behavior change in the changelog.
File summaries
File Description
src/microsoft/opentelemetry/_distro.py Adds per-entry-point dependency conflict checks for httpx and httpx2 before instrumenting.
tests/test_instrumentation_options.py Adds unit tests covering httpx/httpx2 conflict isolation and ensuring other instrumentations are unaffected.
CHANGELOG.md Notes the new independent dependency check behavior for the two entry points.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread CHANGELOG.md
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

Performance comparison

Threshold: regressions >15.0% on gating scenarios fail the build. Higher ops/s is better; positive Δ means the PR is slower.

Scenario Gating Baseline (ops/s) Candidate (ops/s) Δ % Status
azure_monitor_log yes 41,585.2 42,326.3 -1.75%
azure_monitor_span yes 292,397.7 295,858.0 -1.17%
otel_log no 48,517.8 48,398.0 +0.25%
otel_span no 89,790.8 90,612.5 -0.91%

@rads-1996
Radhika Gupta (rads-1996) merged commit 22d3a7e into microsoft:main Sep 4, 2026
12 checks passed
@rads-1996
Radhika Gupta (rads-1996) deleted the add-dep-conflicts-check branch September 4, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants