Add dependency conflict check for httpx and httpx2 since there are two entry points - #259
Merged
Radhika Gupta (rads-1996) merged 4 commits intoSep 4, 2026
Conversation
Copilot started reviewing on behalf of
Radhika Gupta (rads-1996)
September 4, 2026 18:48
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new changelog entry is missing the consistent PR reference/link formatting used elsewhere in the file.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds per-entry-point dependency conflict detection for the httpx and httpx2 OpenTelemetry instrumentations so that a dependency issue in one entry point does not prevent the other from being enabled.
Changes:
- Add an
httpx/httpx2-specific dependency conflict check in_setup_instrumentations()before instrumenting each entry point. - Add tests to validate that dependency conflicts skip only the affected entry point and that non-
httpxinstrumentations do not run the new check. - Document the behavior change in the changelog.
File summaries
| File | Description |
|---|---|
src/microsoft/opentelemetry/_distro.py |
Adds per-entry-point dependency conflict checks for httpx and httpx2 before instrumenting. |
tests/test_instrumentation_options.py |
Adds unit tests covering httpx/httpx2 conflict isolation and ensuring other instrumentations are unaffected. |
CHANGELOG.md |
Notes the new independent dependency check behavior for the two entry points. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Performance comparisonThreshold: regressions >15.0% on gating scenarios fail the build. Higher ops/s is better; positive Δ means the PR is slower.
|
Jackson Weber (JacksonWeber)
approved these changes
Sep 4, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.