nvme_driver: Log pci device id when creating new queues#2906
Merged
gurasinghMS merged 3 commits intomicrosoft:mainfrom Mar 7, 2026
Merged
nvme_driver: Log pci device id when creating new queues#2906gurasinghMS merged 3 commits intomicrosoft:mainfrom
gurasinghMS merged 3 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds PCI device ID context to the create_nvme_io_queue tracing span so queue creation logs can be correlated to a specific NVMe PCI function during multi-queue debugging.
Changes:
- Capture the device’s PCI id as an owned string before awaiting queue creation.
- Include
pci_idas a field on thecreate_nvme_io_queueinfo_span!.
alandau
previously approved these changes
Mar 7, 2026
alandau
approved these changes
Mar 7, 2026
gurasinghMS
added a commit
to gurasinghMS/openvmm
that referenced
this pull request
Mar 7, 2026
Minor change. Came across this issue when debugging a case with several queues. P.S. Had to do some type gymnastics to avoid the immutable reference borrow (string being sent to the info span) (cherry picked from commit 1e28edf)
gurasinghMS
added a commit
to gurasinghMS/openvmm
that referenced
this pull request
Apr 10, 2026
Minor change. Came across this issue when debugging a case with several queues. P.S. Had to do some type gymnastics to avoid the immutable reference borrow (string being sent to the info span) (cherry picked from commit 1e28edf)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor change. Came across this issue when debugging a case with several queues.
P.S. Had to do some type gymnastics to avoid the immutable reference borrow (string being sent to the info span)