nvme_driver: Log pci device id when creating new queues (#2906)#2908
Closed
gurasinghMS wants to merge 1 commit intomicrosoft:release/1.7.2511from
Closed
nvme_driver: Log pci device id when creating new queues (#2906)#2908gurasinghMS wants to merge 1 commit intomicrosoft:release/1.7.2511from
gurasinghMS wants to merge 1 commit intomicrosoft:release/1.7.2511from
Conversation
Minor change. Came across this issue when debugging a case with several queues. P.S. Had to do some type gymnastics to avoid the immutable reference borrow (string being sent to the info span) (cherry picked from commit 1e28edf)
github-actions
bot
added
the
release_1.7.2511
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is a clean cherry-pick of #2906, adding the PCI device ID to the tracing span created when a new NVMe I/O queue is being set up. This helps with debugging scenarios where multiple queues are involved, making it easier to correlate log output with the correct device.
Changes:
- Capture the PCI device ID via
self.device.id().to_owned()to avoid a borrow conflict with the async span. - Pass the captured
pci_idto theinfo_span!("create_nvme_io_queue", ...)call so it appears in queue creation traces.
Contributor
Author
|
Closing this pr. These changes will be bundled together with upcoming changes for hung-on-save fix when create io completion queue commands are slow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean cherry pick of PR #2906
Minor change. Came across this issue when debugging a case with several queues.
P.S. Had to do some type gymnastics to avoid the immutable reference borrow (string being sent to the info span)