loader/uefi: fix uefi enlightened snp cpuid page generation - #3965
Merged
Conversation
Steven Malis (smalis-msft)
approved these changes
Jul 17, 2026
Contributor
|
Whoops lol |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes construction of the AMD SEV-SNP CPUID page for the UEFI loader by correctly populating the CPUID input subleaf value (ecx_in) rather than incorrectly writing it into an output register field. This aligns UEFI’s behavior with the existing paravisor CPUID page generation logic.
Changes:
- Write
required_leaf.ecxtoHV_PSP_CPUID_LEAF.ecx_ininstead ofeax_outwhen building the SNP CPUID page. - Keeps CPUID page initialization consistent with the pattern used in
vm/loader/src/paravisor.rs.
Chris Oo (chris-oo)
enabled auto-merge (squash)
July 17, 2026 21:28
sluck-msft
approved these changes
Jul 17, 2026
Mike Ebersol (mebersol)
added
the
backport_1.8.2607
Matt LaFayette (Kurjanowicz) (mattkur)
added a commit
that referenced
this pull request
Aug 4, 2026
Member
|
Backported to release/1.8.2607 in #4130 |
Ben Hillis (benhillis)
added
backported_1.8.2607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seemed to have been a bug forever, but this configuration is not well tested. Now matches what we do for openhcl in paravisor.rs.