nvme: Quiet some noisy logs during vmm tests - #4070
Merged
Steven Malis (smalis-msft) merged 1 commit intoJul 29, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces NVMe admin-path log volume during VMM test runs by lowering high-frequency tracing events from debug to trace, keeping detailed command/namespace diagnostics available when explicitly enabling trace-level logging.
Changes:
- Lower per-admin-command logging from
debugtotracein the NVMe admin worker. - Lower “inactive namespace id” logging from
debugtotracein both the NVMe device and its nvme_test counterpart.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vm/devices/storage/nvme/src/workers/admin.rs | Demotes noisy admin command and inactive-namespace logs to trace to reduce routine test log spam. |
| vm/devices/storage/nvme_test/src/workers/admin.rs | Mirrors the inactive-namespace log demotion to trace in the test worker implementation. |
Steven Malis (smalis-msft)
added
the
backport_1.8.2607
Steven Malis (smalis-msft)
enabled auto-merge (squash)
July 29, 2026 15:24
Steven Malis (smalis-msft)
removed
the
backport_1.8.2607
John Starks (jstarks)
approved these changes
Jul 29, 2026
Steven Malis (smalis-msft)
merged commit Jul 29, 2026
89a26b1
into
microsoft:main
97 of 98 checks passed
Steven Malis (smalis-msft)
added
the
backport_1.8.2607
Steven Malis (smalis-msft)
removed
the
backport_1.8.2607
Steven Malis (smalis-msft)
added a commit
that referenced
this pull request
Aug 4, 2026
Backport of #4070 to `release/1.8.2607`. The cherry-pick of 89a26b1 applied cleanly onto `release/1.8.2607` with no conflicts and no manual edits. Original PR: #4070 --- *This backport PR was created by an AI agent (GitHub Copilot) on behalf of @smalis-msft.*
Member
|
Backported to release/1.8.2607 in #4124 |
Ben Hillis (benhillis)
added
the
backported_1.8.2607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tracing statements take up a lot of space in nvme tests runs (example: https://openvmm.dev/test-results/#/runs/30395677982/x64-windows-intel-mi-secure-vmm-tests-logs/multiarch__openvmm_openhcl_uefi_x64_windows_datacenter_core_2022_x64_uefi_force_dma_bounce?log=831). Lower them to trace level.