snp: update family id that to be shared across OpenHCL verions - #4183
Merged
Ming-Wei Shih (mingweishih) merged 1 commit intoAug 7, 2026
Merged
Conversation
Ming-Wei Shih (mingweishih)
added
the
backport_1.8.2607
Ming-Wei Shih (mingweishih)
requested review from
Jenna Goddard (jennagoddard),
Mike Ebersol (mebersol) and
Mike Stunes (stunes-ms)
August 7, 2026 00:03
Contributor
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Updates the SNP family ID constant to remove version-specific bytes so the attestation “family id” is consistent across OpenHCL versions.
Changes:
- Modify
SNP_FAMILY_IDbyte sequence to a version-independent value.
Copilot started reviewing on behalf of
Ming-Wei Shih (mingweishih)
August 7, 2026 00:21
View session
Copilot started reviewing on behalf of
Ming-Wei Shih (mingweishih)
August 7, 2026 03:44
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
vm/loader/igvmfilegen/src/snp_id_block.rs:52
SNP_IMAGE_IDis now set to the ASCII bytes for "openhcl" (NUL-padded), but the pinned-bytes unit test insnp_id_block_constants_byte_identitystill asserts*b"underhill\0\0\0\0\0\0\0", which will fail. Also, the doc comment still says "OpenHCL/Underhill" even though the new identifier is no longer "underhill"; consider updating the wording to match the new value (e.g., "OpenHCL guests").
/// SNP image identifier for OpenHCL/Underhill guests.
pub const SNP_IMAGE_ID: [u8; 16] = [
b'o', b'p', b'e', b'n', b'h', b'c', b'l', 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
];
- Set SNP family ID to the OpenHCL byte scheme and document the layout convention: byte[3]=0x01; all other bytes reserved as 0x00. - Set SNP image ID to openhcl with explicit 16-byte representation. - Update SNP ID block unit-test identity expectations accordingly.
Ming-Wei Shih (mingweishih)
force-pushed
the
fix_family_id
branch
from
August 7, 2026 03:55
8db4f7a to
8300071
Compare
Copilot started reviewing on behalf of
Ming-Wei Shih (mingweishih)
August 7, 2026 03:56
View session
Steven Malis (smalis-msft)
approved these changes
Aug 7, 2026
Ming-Wei Shih (mingweishih)
merged commit Aug 7, 2026
75e780a
into
microsoft:main
68 of 69 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the version-specific value from family id, making it consistent across all OpenHCL versions