Per URL cache - #15
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a short-lived per-URL proxy resolution cache to reduce repeated OS/PAC/WPAD work, and documents the new behavior across the crate docs and README.
Changes:
- Added per-URL proxy decision caching with TTL and capacity controls, invalidated by OS config generation changes.
- Integrated cache lookup/write into synchronous resolution and cache lookup into the async API (with async resolution still performed via the worker thread).
- Updated crate-level docs and README to describe completed-resolution caching behavior and its relationship to change notifications.
Show a summary per file
| File | Description |
|---|---|
src/resolver.rs |
Introduces per-URL resolution cache data structures, options, lookup/store logic, and tests validating generation invalidation/keying. |
src/lib.rs |
Updates public documentation to mention per-URL caching and reframes change-notification primitives. |
README.md |
Documents default 30s completed-resolution caching and immediate invalidation on OS config changes. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Low
Christof Marti (chrmarti)
marked this pull request as ready for review
July 16, 2026 09:11
Christof Marti (chrmarti)
enabled auto-merge (squash)
July 16, 2026 09:11
Alex Ross (alexr00)
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.