Skip to content

Make PAC backends platform-aware - #16

Merged
Christof Marti (chrmarti) merged 1 commit into
mainfrom
chrmarti/used-seahorse
Jul 16, 2026
Merged

Make PAC backends platform-aware#16
Christof Marti (chrmarti) merged 1 commit into
mainfrom
chrmarti/used-seahorse

Conversation

@chrmarti

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings July 16, 2026 13:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Unifies PAC/WPAD resolution by enabling embedded PAC backends on Windows while retaining WinHTTP for backend-less builds.

Changes:

  • Routes Windows PAC evaluation and DNS WPAD through embedded backends.
  • Shares PAC fetching across platforms.
  • Updates CI, examples, licensing, and documentation.
Show a summary per file
File Description
Cargo.toml Makes ureq cross-platform and updates feature guidance.
src/resolver.rs Selects embedded or WinHTTP resolution paths.
src/platform/windows.rs Limits WinHTTP PAC APIs to backend-less builds.
src/platform/mod.rs Conditionally exports the WinHTTP resolver.
src/fetch.rs Uses the shared ureq fetcher on Windows.
src/wpad.rs Documents Windows WPAD behavior.
src/pac/mod.rs Documents cross-platform PAC evaluation.
src/types.rs Updates PAC backend API documentation.
src/lib.rs Updates platform behavior documentation.
examples/proxytester.rs Handles local PAC files by backend configuration.
examples/pac_bench.rs Separates WinHTTP and embedded benchmarks.
.github/workflows/ci.yml Builds and benchmarks the new Windows variants.
README.md Documents unified backend behavior.
LICENSE.txt Updates QuickJS platform scope.
ThirdPartyNotices.txt Regenerates dependency notices.
about.toml Updates notice-generation guidance.
about.hbs Updates generated notice text.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 17/17 changed files
  • Comments generated: 1
  • Review effort level: Medium

Comment thread Cargo.toml Outdated
@chrmarti Christof Marti (chrmarti) changed the title Unify implementation across platforms Make PAC backends platform-aware Jul 16, 2026
@chrmarti
Christof Marti (chrmarti) merged commit d050ea2 into main Jul 16, 2026
26 checks passed
@chrmarti
Christof Marti (chrmarti) deleted the chrmarti/used-seahorse branch July 16, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants