Make PAC backends platform-aware - #16
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Unifies PAC/WPAD resolution by enabling embedded PAC backends on Windows while retaining WinHTTP for backend-less builds.
Changes:
- Routes Windows PAC evaluation and DNS WPAD through embedded backends.
- Shares PAC fetching across platforms.
- Updates CI, examples, licensing, and documentation.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Makes ureq cross-platform and updates feature guidance. |
src/resolver.rs |
Selects embedded or WinHTTP resolution paths. |
src/platform/windows.rs |
Limits WinHTTP PAC APIs to backend-less builds. |
src/platform/mod.rs |
Conditionally exports the WinHTTP resolver. |
src/fetch.rs |
Uses the shared ureq fetcher on Windows. |
src/wpad.rs |
Documents Windows WPAD behavior. |
src/pac/mod.rs |
Documents cross-platform PAC evaluation. |
src/types.rs |
Updates PAC backend API documentation. |
src/lib.rs |
Updates platform behavior documentation. |
examples/proxytester.rs |
Handles local PAC files by backend configuration. |
examples/pac_bench.rs |
Separates WinHTTP and embedded benchmarks. |
.github/workflows/ci.yml |
Builds and benchmarks the new Windows variants. |
README.md |
Documents unified backend behavior. |
LICENSE.txt |
Updates QuickJS platform scope. |
ThirdPartyNotices.txt |
Regenerates dependency notices. |
about.toml |
Updates notice-generation guidance. |
about.hbs |
Updates generated notice text. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 17/17 changed files
- Comments generated: 1
- Review effort level: Medium
Christof Marti (chrmarti)
force-pushed
the
chrmarti/used-seahorse
branch
from
July 16, 2026 15:16
6fb8f89 to
bf1c970
Compare
Paul (pwang347)
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.