Add details to proxy config - #19
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds richer proxy configuration diagnostics across Rust and Node.js APIs.
Changes:
- Reports environment proxy variables and per-source PAC status.
- Adds Windows DHCP WPAD discovery and distinguishes DHCP/DNS sources.
- Updates bindings, types, tests, and documentation.
Show a summary per file
| File | Description |
|---|---|
src/wpad.rs |
Adds DNS WPAD source/status reporting. |
src/types.rs |
Defines diagnostic configuration types. |
src/resolver.rs |
Inspects and prioritizes PAC sources. |
src/platform/windows.rs |
Adds DHCP WPAD URL detection. |
src/platform/mod.rs |
Exposes Windows DHCP detection. |
src/lib.rs |
Exports new public types and updates docs. |
src/env_cfg.rs |
Captures environment diagnostics. |
README.md |
Documents expanded configuration inspection. |
npm/test/smoke.js |
Tests the expanded Node.js response. |
npm/native/src/lib.rs |
Maps diagnostics into Node.js objects. |
index.d.ts |
Defines the expanded TypeScript API. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 10/11 changed files
- Comments generated: 2
- Review effort level: Medium
Christof Marti (chrmarti)
force-pushed
the
chrmarti/yabbering-elk
branch
from
July 17, 2026 10:21
a4d9333 to
4890d80
Compare
Christof Marti (chrmarti)
enabled auto-merge
July 17, 2026 10:22
Martin Aeschlimann (aeschli)
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.