Use in-process GIO for Linux proxy settings - #22
Draft
Christof Marti (chrmarti) wants to merge 4 commits into
Draft
Use in-process GIO for Linux proxy settings#22Christof Marti (chrmarti) wants to merge 4 commits into
Christof Marti (chrmarti) wants to merge 4 commits into
Conversation
Load GLib/GIO at runtime for typed proxy configuration reads and change notifications on a private main-context thread, removing the dconf and gsettings child processes without adding hard system-library dependencies. Raise the repository MSRV to Rust 1.94 and enforce it in CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Align the npm facade and all platform packages on version 0.5.0 for the in-process GIO release. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Replaces Linux proxy subprocesses with runtime-loaded GIO while avoiding hard GLib dependencies.
Changes:
- Adds typed GSettings reads and in-process change watching.
- Raises MSRV to Rust 1.94 and adds CI enforcement.
- Prepares npm packages for version 0.5.0.
Show a summary per file
| File | Description |
|---|---|
src/platform/gio.rs |
Implements dynamic GIO access and watching. |
src/platform/linux.rs |
Integrates GIO proxy configuration. |
src/platform/mod.rs |
Updates watcher documentation. |
README.md |
Documents Linux GIO behavior and MSRV. |
CHANGELOG.md |
Records the 0.5.0 changes. |
Cargo.toml |
Raises MSRV and adds libloading. |
Cargo.lock |
Locks libloading. |
pac-wasm-guest/Cargo.toml |
Raises guest MSRV. |
npm/native/Cargo.toml |
Raises addon MSRV. |
npm/native/Cargo.lock |
Updates addon dependencies. |
package.json |
Bumps facade and platform dependencies. |
npm/platforms/darwin-arm64/package.json |
Bumps package version. |
npm/platforms/darwin-x64/package.json |
Bumps package version. |
npm/platforms/linux-arm-gnueabihf/package.json |
Bumps package version. |
npm/platforms/linux-arm64-gnu/package.json |
Bumps package version. |
npm/platforms/linux-arm64-musl/package.json |
Bumps package version. |
npm/platforms/linux-x64-gnu/package.json |
Bumps package version. |
npm/platforms/linux-x64-musl/package.json |
Bumps package version. |
npm/platforms/win32-arm64-msvc/package.json |
Bumps package version. |
npm/platforms/win32-x64-msvc/package.json |
Bumps package version. |
ThirdPartyNotices.txt |
Adds the libloading license. |
.github/workflows/ci.yml |
Adds Rust 1.94 MSRV checks. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 20/22 changed files
- Comments generated: 3
- Review effort level: Balanced
Use the repository release version for the root crate, Node addon, and PAC guest, and refresh their lockfile package records. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Make the sibling GIO module path explicit, run all OS integration tests in the dedicated CI job, refresh crate documentation, and regenerate notices for version 0.5.0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Christof Marti (chrmarti)
marked this pull request as ready for review
August 25, 2026 16:00
Christof Marti (chrmarti)
marked this pull request as draft
August 25, 2026 16:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the Linux
dconf/gsettingschild processes with runtime-loaded, in-process GIO configuration reads and change notifications.org.gnome.system.proxythrough typed GSettings APIsValidation
dbus-run-sessiontests for typed reads and root/child notifications