feat: Introduce cargo-gamma - #93
Conversation
|
There was a problem hiding this comment.
Pull request overview
Introduces cargo-gamma, a Rust mutation-testing Cargo subcommand with instrumentation, runtime activation, process supervision, reporting, and workspace integration.
Changes:
- Adds CLI, engine, attribute, runtime, process, and platform crates.
- Adds execution, reporting, configuration, documentation, fixtures, and tests.
- Integrates the new tooling into workspace metadata and automation.
Review findings:
- Critical (1 vote):
crates/cargo-gamma-lib/src/exec/manifest.rs:179,187may incorrectly treatcargo-gamma-rtas satisfying thegamma_rtdependency, leaving generated guards uncompilable. - Moderate (2 votes):
justfiles/basic.just:102,106passes binary-only crates tocargo doc2readme --lib. - Nits (3 votes each): Eight crate design documents use
docs/DESIGN.mdinstead of the requireddocs/design/README.md.
Reviewed changes
Copilot reviewed 80 out of 275 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Reviewed change |
|---|---|
README.md |
Lists cargo-gamma. |
justfiles/basic.just |
Updates README automation. |
crates/cargo-gamma/tests/manual.rs |
Manual command parsing tests. |
crates/cargo-gamma/src/real_host.rs |
Real process host. |
crates/cargo-gamma/logo.png |
Package artwork. |
crates/cargo-gamma/favicon.ico |
Package favicon. |
crates/cargo-gamma/CHANGELOG.md |
CLI changelog. |
crates/cargo-gamma/Cargo.toml |
CLI package metadata. |
crates/cargo-gamma-unsafe/src/support.rs |
Capability detection. |
crates/cargo-gamma-unsafe/src/lib.rs |
Platform API. |
crates/cargo-gamma-unsafe/README.md |
Platform documentation. |
crates/cargo-gamma-unsafe/logo.png |
Package artwork. |
crates/cargo-gamma-unsafe/favicon.ico |
Package favicon. |
crates/cargo-gamma-unsafe/docs/DESIGN.md |
Platform design documentation. |
crates/cargo-gamma-unsafe/Cargo.toml |
Platform package metadata. |
crates/cargo-gamma-rt/logo.png |
Package artwork. |
crates/cargo-gamma-rt/favicon.ico |
Package favicon. |
crates/cargo-gamma-rt/docs/DESIGN.md |
Runtime design documentation. |
crates/cargo-gamma-rt/Cargo.toml |
Runtime package metadata. |
crates/cargo-gamma-process/src/memory_usage.rs |
Memory usage. |
crates/cargo-gamma-process/src/memory_request.rs |
Memory requests. |
crates/cargo-gamma-process/src/lib.rs |
Process API. |
crates/cargo-gamma-process/src/faults.rs |
Process faults. |
crates/cargo-gamma-process/README.md |
Process documentation. |
crates/cargo-gamma-process/logo.png |
Package artwork. |
crates/cargo-gamma-process/favicon.ico |
Package favicon. |
crates/cargo-gamma-process/docs/DESIGN.md |
Process design documentation. |
crates/cargo-gamma-process/Cargo.toml |
Process package metadata. |
crates/cargo-gamma-lib/tests/gate.rs |
Coverage gate tests. |
crates/cargo-gamma-lib/tests/fixtures/report.golden.json |
Golden report fixture. |
crates/cargo-gamma-lib/tests/agreement.rs |
Agreement tests. |
crates/cargo-gamma-lib/src/vendor/VERSION |
Vendored schema version. |
crates/cargo-gamma-lib/src/suppress/mod.rs |
Suppression module. |
crates/cargo-gamma-lib/src/suppress/intent.rs |
Suppression intent. |
crates/cargo-gamma-lib/src/suppress/idle.rs |
Idle suppressions. |
crates/cargo-gamma-lib/src/suppress/apply.rs |
Suppression application. |
crates/cargo-gamma-lib/src/schema.rs |
Schema integration. |
crates/cargo-gamma-lib/src/report/text.rs |
Text reports. |
crates/cargo-gamma-lib/src/report/mod.rs |
Reporting module. |
crates/cargo-gamma-lib/src/parse.rs |
Input parsing. |
crates/cargo-gamma-lib/src/ops/registry.rs |
Registry operations. |
crates/cargo-gamma-lib/src/ops/collect.rs |
Collection operations. |
crates/cargo-gamma-lib/src/ops.rs |
Library operations. |
crates/cargo-gamma-lib/src/model/suppression.rs |
Suppression model. |
crates/cargo-gamma-lib/src/model/summary.rs |
Mutation summaries. |
crates/cargo-gamma-lib/src/model/scoring.rs |
Mutation scoring. |
crates/cargo-gamma-lib/src/model/mod.rs |
Model module. |
crates/cargo-gamma-lib/src/model/interner.rs |
Model interning. |
crates/cargo-gamma-lib/src/model/identity.rs |
Model identities. |
crates/cargo-gamma-lib/src/migrate/translation.rs |
Configuration translation. |
crates/cargo-gamma-lib/src/migrate/paths.rs |
Migration paths. |
crates/cargo-gamma-lib/src/migrate/mod.rs |
Migration module. |
crates/cargo-gamma-lib/src/migrate/lock_flags.rs |
Lock flag migration. |
crates/cargo-gamma-lib/src/merge/verdict.rs |
Merged verdicts. |
crates/cargo-gamma-lib/src/merge/status.rs |
Merge status. |
crates/cargo-gamma-lib/src/merge/mod.rs |
Merge module. |
crates/cargo-gamma-lib/src/merge/incoming.rs |
Merge inputs. |
crates/cargo-gamma-lib/src/fix/verify.rs |
Fix verification entry. |
crates/cargo-gamma-lib/src/fix/verification.rs |
Fix verification. |
crates/cargo-gamma-lib/src/fix/removal.rs |
Fix removal. |
crates/cargo-gamma-lib/src/fix/mod.rs |
Fix module. |
crates/cargo-gamma-lib/src/fix/edit.rs |
Fix edits. |
crates/cargo-gamma-lib/src/exec/mod.rs |
Execution module. |
crates/cargo-gamma-lib/src/exec/incremental_mode.rs |
Incremental execution. |
crates/cargo-gamma-lib/src/elements/mod.rs |
Elements module. |
crates/cargo-gamma-lib/src/elements/digest.rs |
Report digests. |
crates/cargo-gamma-lib/src/discover/target_file.rs |
Target files. |
crates/cargo-gamma-lib/src/discover/shard.rs |
Discovery sharding. |
crates/cargo-gamma-lib/src/discover/mod.rs |
Discovery module. |
crates/cargo-gamma-lib/src/diag/mod.rs |
Diagnostics module. |
crates/cargo-gamma-lib/src/commands/when.rs |
Conditional command. |
crates/cargo-gamma-lib/src/commands/verdict_log.rs |
Verdict logging. |
crates/cargo-gamma-lib/src/commands/mod.rs |
Command module. |
crates/cargo-gamma-lib/src/commands/host.rs |
Host command. |
crates/cargo-gamma-lib/src/commands/hints.rs |
Hints command. |
crates/cargo-gamma-lib/src/commands/explain.rs |
Explanation command. |
crates/cargo-gamma-lib/src/commands/completions.rs |
Shell completions. |
crates/cargo-gamma-lib/src/ci/truncation.rs |
Output truncation. |
crates/cargo-gamma-lib/src/ci/mod.rs |
CI integration. |
crates/cargo-gamma-lib/src/ci/level.rs |
CI severity levels. |
crates/cargo-gamma-lib/src/ci/finding.rs |
CI findings. |
crates/cargo-gamma-lib/src/cfg/mod.rs |
CFG module. |
crates/cargo-gamma-lib/src/cfg/cfgs.rs |
CFG values. |
crates/cargo-gamma-lib/src/advise/yield_.rs |
Yield advice. |
crates/cargo-gamma-lib/src/advise/timing.rs |
Timing advice. |
crates/cargo-gamma-lib/src/advise/text.rs |
Advice text. |
crates/cargo-gamma-lib/src/advise/mod.rs |
Advice module. |
crates/cargo-gamma-lib/src/advise/finding.rs |
Advice findings. |
crates/cargo-gamma-lib/README.md |
Library documentation. |
crates/cargo-gamma-lib/logo.png |
Package artwork. |
crates/cargo-gamma-lib/favicon.ico |
Package favicon. |
crates/cargo-gamma-lib/docs/DESIGN.md |
Library design documentation. |
crates/cargo-gamma-lib/Cargo.toml |
Library package metadata. |
crates/cargo-gamma-engine/src/parse/mod.rs |
Parsing module. |
crates/cargo-gamma-engine/src/ops/registry/preset.rs |
Mutator presets. |
crates/cargo-gamma-engine/src/ops/registry/mutator.rs |
Mutator definitions. |
crates/cargo-gamma-engine/src/ops/registry/mod.rs |
Registry module. |
crates/cargo-gamma-engine/src/ops/registry/lookup.rs |
Mutator lookup. |
crates/cargo-gamma-engine/src/ops/mod.rs |
Engine operations. |
crates/cargo-gamma-engine/src/ops/collect/traversal.rs |
AST traversal. |
crates/cargo-gamma-engine/src/ops/collect/shape.rs |
Instrumentation shapes. |
crates/cargo-gamma-engine/src/ops/collect/mod.rs |
Collection module. |
crates/cargo-gamma-engine/src/ops/collect/definitions.rs |
Candidate definitions. |
crates/cargo-gamma-engine/src/ops/collect/collector/tables.rs |
Table collection. |
crates/cargo-gamma-engine/src/ops/collect/candidate.rs |
Candidate collection. |
crates/cargo-gamma-engine/src/model/mutation_site.rs |
Mutation locations. |
crates/cargo-gamma-engine/src/model/mutant_definition.rs |
Mutant definitions. |
crates/cargo-gamma-engine/src/model/mod.rs |
Model module. |
crates/cargo-gamma-engine/src/model/interner.rs |
Model interning. |
crates/cargo-gamma-engine/src/lib.rs |
Engine API. |
crates/cargo-gamma-engine/src/error.rs |
Engine errors. |
crates/cargo-gamma-engine/README.md |
Engine documentation. |
crates/cargo-gamma-engine/logo.png |
Package artwork. |
crates/cargo-gamma-engine/favicon.ico |
Package favicon. |
crates/cargo-gamma-engine/docs/DESIGN.md |
Engine design documentation. |
crates/cargo-gamma-engine/Cargo.toml |
Engine package metadata. |
crates/cargo-gamma-attrs/logo.png |
Package artwork. |
crates/cargo-gamma-attrs/favicon.ico |
Package favicon. |
crates/cargo-gamma-attrs/docs/DESIGN.md |
Attribute design documentation. |
crates/cargo-gamma-attrs/Cargo.toml |
Attribute package metadata. |
crates/cargo-gamma-attrs-impl/src/lib.rs |
Attribute parsing API. |
crates/cargo-gamma-attrs-impl/README.md |
Implementation documentation. |
crates/cargo-gamma-attrs-impl/logo.png |
Package artwork. |
crates/cargo-gamma-attrs-impl/favicon.ico |
Package favicon. |
crates/cargo-gamma-attrs-impl/docs/DESIGN.md |
Attribute implementation design. |
crates/cargo-gamma-attrs-impl/Cargo.toml |
Implementation package metadata. |
crates/cargo-each/src/main.rs |
Binary entry point. |
crates/cargo-each/README.md |
Tool documentation. |
crates/cargo-each/Cargo.toml |
Package metadata. |
crates/cargo-aprz-lib/Cargo.toml |
Package metadata. |
CHANGELOG.md |
Project changelog. |
Cargo.toml |
Workspace metadata. |
.cargo/mutants.toml |
Mutation exclusions. |
.cargo/gamma.toml |
Gamma configuration. |
Suppressed comments (2)
crates/cargo-gamma-engine/src/ops/collect/collector.rs:512
- Excluding integer literals here means an explicit
expr.incrementorexpr.decrementselection produces no mutation for a numeric function tail:visit_expr_litemits onlyliteral.*variants. The emission deduplication is per mutator, so the literal guard does not make these expression mutators duplicates; letperturb_provenrun for literals as well.
crates/cargo-gamma-engine/src/ops/collect/collector.rs:1742 - This repeats the literal exclusion for
return 1: the literal visitor does not emitexpr.*, so selecting onlyexpr.incrementorexpr.decrementsilently omits numeric return sites. The call should also run for literals; the emission path already distinguishes mutator names when de-duplicating.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
2092854 to
7a64c1d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 76 out of 275 changed files in this pull request and generated 2 comments.
Suppressed comments (6)
crates/cargo-gamma-attrs-impl/docs/DESIGN.md:1
- The repository's required top-level design-document layout is
docs/design/README.md(seeAGENTS.md:41-46), but this document is added asdocs/DESIGN.md. The design artifact is therefore not at the path used by the repository's documentation and regression checks; please move it to the required path.
crates/cargo-gamma-attrs/docs/DESIGN.md:1 - The repository's required top-level design-document layout is
docs/design/README.md(seeAGENTS.md:41-46), but this document is added asdocs/DESIGN.md. The design artifact is therefore not at the required path; please move it todocs/design/README.md.
crates/cargo-gamma-engine/docs/DESIGN.md:1 - The repository's required top-level design-document layout is
docs/design/README.md(seeAGENTS.md:41-46), but this document is added asdocs/DESIGN.md. The design artifact is therefore not at the required path; please move it todocs/design/README.md.
crates/cargo-gamma-engine/src/ops/collect/collector.rs:1770 - These replacements cover the entire literal span, but
base10_digits()omits the integer suffix and every emitted string drops it. A valid site such asuse_t(1u8)where a trait is implemented only foru8then becomes an unviable or differently typed mutant (use_t(1)); appendvalue.suffix()to each generated integer replacement, including the zero/one forms, so mutation changes the value without changing its type.
crates/cargo-gamma-engine/src/ops/collect/collector.rs:1764 - Parsing
base10_digits()asi64silently skips the increment/decrement family for validu64/u128literals abovei64::MAX(for example,u64::MAXhas no neighboring-value mutants). Parse according to the literal's signedness/width with checked arithmetic so large unsigned literals still get their valid decrement candidate and do not disappear from the catalog.
crates/cargo-gamma-lib/docs/DESIGN.md:1 - The repository's required top-level design-document layout is
docs/design/README.md(seeAGENTS.md:41-46), but this document is added asdocs/DESIGN.md. The design artifact is therefore not at the required path; please move it todocs/design/README.md.
7a64c1d to
e865613
Compare
e865613 to
2e5513e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 77 out of 276 changed files in this pull request and generated no new comments.
Suppressed comments (4)
crates/cargo-gamma-attrs-impl/docs/DESIGN.md:1
- The repository requires each crate's design landing page at
docs/design/README.md(AGENTS.md:41-46, 91-93), but this document is added asdocs/DESIGN.md. Move it to the required path so the crate follows the repository contract and remains discoverable by tooling and documentation.
crates/cargo-gamma-attrs/docs/DESIGN.md:1 - The repository requires each crate's design landing page at
docs/design/README.md(AGENTS.md:41-46, 91-93), but this document is added asdocs/DESIGN.md. Move it to the required path so the crate follows the repository contract and remains discoverable by tooling and documentation.
crates/cargo-gamma-engine/docs/DESIGN.md:1 - The repository requires each crate's design landing page at
docs/design/README.md(AGENTS.md:41-46, 91-93), but this document is added asdocs/DESIGN.md. Move it to the required path so the crate follows the repository contract and remains discoverable by tooling and documentation.
crates/cargo-gamma-lib/docs/DESIGN.md:1 - The repository requires each crate's design landing page at
docs/design/README.md(AGENTS.md:41-46, 91-93), but this document is added asdocs/DESIGN.md. Move it to the required path so the crate follows the repository contract and remains discoverable by tooling and documentation.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 77 out of 276 changed files in this pull request and generated no new comments.
Suppressed comments (5)
CHANGELOG.md:11
- This new crate link is a manual edit to the repository changelog, but
AGENTS.md:23-25requires changelogs to be generated/updated by the release process. Please remove this entry from the feature PR and let the release tooling add it.
crates/cargo-gamma-attrs-impl/docs/DESIGN.md:1 - This new crate's design document is at
docs/DESIGN.md, but the repository's required layout for new crates isdocs/design/README.md(seeAGENTS.md:39-47). Please move this document to that landing-page path so the design contract is discoverable and consistent with the other crates.
crates/cargo-gamma-attrs/docs/DESIGN.md:1 - This new crate's design document is at
docs/DESIGN.md, but the repository's required layout for new crates isdocs/design/README.md(seeAGENTS.md:39-47). Please move this document to that landing-page path so the design contract is discoverable and consistent with the other crates.
crates/cargo-gamma-engine/docs/DESIGN.md:1 - This new crate's design document is at
docs/DESIGN.md, but the repository's required layout for new crates isdocs/design/README.md(seeAGENTS.md:39-47). Please move this document to that landing-page path so the design contract is discoverable and consistent with the other crates.
crates/cargo-gamma-lib/docs/DESIGN.md:1 - This new crate's design document is at
docs/DESIGN.md, but the repository's required layout for new crates isdocs/design/README.md(seeAGENTS.md:39-47). Please move this document to that landing-page path so the design contract is discoverable and consistent with the other crates.
2e5513e to
ba52dd1
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 76 out of 275 changed files in this pull request and generated 1 comment.
Suppressed comments (4)
crates/cargo-gamma-attrs-impl/docs/DESIGN.md:1
- This new crate design document is stored at
docs/DESIGN.md, but every new crate must provide its top-level design landing page atdocs/design/README.md. Please relocate this document to that path so the repository's design-doc discovery and publication conventions work.
crates/cargo-gamma-attrs/docs/DESIGN.md:1 - This new crate design document is stored at
docs/DESIGN.md, but every new crate must provide its top-level design landing page atdocs/design/README.md. Please relocate this document to that path so the repository's design-doc discovery and publication conventions work.
crates/cargo-gamma-engine/docs/DESIGN.md:1 - This new crate design document is stored at
docs/DESIGN.md, but every new crate must provide its top-level design landing page atdocs/design/README.md. Please relocate this document to that path so the repository's design-doc discovery and publication conventions work.
crates/cargo-gamma-lib/docs/DESIGN.md:1 - This new crate design document is stored at
docs/DESIGN.md, but every new crate must provide its top-level design landing page atdocs/design/README.md. Please relocate this document to that path so the repository's design-doc discovery and publication conventions work.
ba52dd1 to
9a81538
Compare
9a81538 to
94afcdb
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 76 out of 275 changed files in this pull request and generated 1 comment.
Suppressed comments (4)
crates/cargo-gamma-attrs-impl/docs/DESIGN.md:1
- The design document is at
docs/DESIGN.md, but the repository contract for new crates requirescrates/<crate>/docs/design/README.md. Please move this file to the required path so design-doc tooling and reviewers can discover it consistently.
crates/cargo-gamma-attrs/docs/DESIGN.md:1 - The design document is at
docs/DESIGN.md, but the repository contract for new crates requirescrates/<crate>/docs/design/README.md. Please move this file to the required path so design-doc tooling and reviewers can discover it consistently.
crates/cargo-gamma-engine/docs/DESIGN.md:1 - The design document is at
docs/DESIGN.md, but the repository contract for new crates requirescrates/<crate>/docs/design/README.md. Please move this file to the required path so design-doc tooling and reviewers can discover it consistently.
crates/cargo-gamma-lib/docs/DESIGN.md:1 - The design document is at
docs/DESIGN.md, but the repository contract for new crates requirescrates/<crate>/docs/design/README.md. Please move this file to the required path so design-doc tooling and reviewers can discover it consistently.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 79 out of 287 changed files in this pull request and generated no new comments.
Suppressed comments (4)
crates/cargo-gamma-lib/docs/DESIGN.md:5
- AGENTS.md specifies design docs should be under
crates/<crate>/docs/design/README.md. This file is added asdocs/DESIGN.md, which diverges from the repository’s documented layout for new crates/changes.
crates/cargo-gamma-engine/docs/DESIGN.md:5 - AGENTS.md documents
crates/<crate>/docs/design/README.mdas the expected design-doc location. Adding adocs/DESIGN.mdfile here diverges from that convention.
crates/cargo-gamma-attrs/docs/DESIGN.md:5 - AGENTS.md specifies design docs under
crates/<crate>/docs/design/README.md. This crate addsdocs/DESIGN.md, which doesn’t follow that documented layout.
crates/cargo-gamma-attrs-impl/docs/DESIGN.md:5 - AGENTS.md documents
crates/<crate>/docs/design/README.mdas the standard design doc location. This crate addsdocs/DESIGN.mdinstead, which diverges from that convention.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 78 out of 286 changed files in this pull request and generated no new comments.
Suppressed comments (4)
crates/cargo-gamma-lib/docs/DESIGN.md:4
- Repo convention is that design docs live at
crates/<crate>/docs/design/README.md(AGENTS.md:39-47, 91-93). This crate addsdocs/DESIGN.mdinstead, which won't match the expected layout or render as thedocs/design/landing page. Please move/rename this intodocs/design/README.md(and adjust any links accordingly).
crates/cargo-gamma-engine/docs/DESIGN.md:4 - Repo convention is that design docs live at
crates/<crate>/docs/design/README.md(AGENTS.md:39-47, 91-93). This crate addsdocs/DESIGN.mdinstead, which won't match the expected layout or render as thedocs/design/landing page. Please move/rename this intodocs/design/README.md(and adjust any links accordingly).
crates/cargo-gamma-attrs/docs/DESIGN.md:4 - Repo convention is that design docs live at
crates/<crate>/docs/design/README.md(AGENTS.md:39-47, 91-93). This crate addsdocs/DESIGN.mdinstead, which won't match the expected layout or render as thedocs/design/landing page. Please move/rename this intodocs/design/README.md(and adjust any links accordingly).
crates/cargo-gamma-attrs-impl/docs/DESIGN.md:4 - Repo convention is that design docs live at
crates/<crate>/docs/design/README.md(AGENTS.md:39-47, 91-93). This crate addsdocs/DESIGN.mdinstead, which won't match the expected layout or render as thedocs/design/landing page. Please move/rename this intodocs/design/README.md(and adjust any links accordingly).
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 78 out of 286 changed files in this pull request and generated no new comments.
Suppressed comments (1)
crates/cargo-gamma-lib/docs/DESIGN.md:4
- New crates are expected to land their top-level design doc at
docs/design/README.md(seeAGENTS.md), so it renders as thedocs/design/landing page and stays consistent with the repo’s design-doc layout. This crate currently addsdocs/DESIGN.mdinstead, which diverges from that convention.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 78 out of 286 changed files in this pull request and generated 1 comment.
Suppressed comments (4)
crates/cargo-gamma-lib/docs/DESIGN.md:4
- Repo convention is
crates/<crate>/docs/design/README.mdfor the crate design doc landing page (see AGENTS.md layout section). This file should be moved/renamed accordingly so it renders as the design doc root.
crates/cargo-gamma-engine/docs/DESIGN.md:4 - Repo convention is
crates/<crate>/docs/design/README.mdfor the crate design doc landing page (see AGENTS.md layout section). This file should be moved/renamed accordingly so it renders as the design doc root.
crates/cargo-gamma-attrs/docs/DESIGN.md:4 - Repo convention is
crates/<crate>/docs/design/README.mdfor the crate design doc landing page (see AGENTS.md layout section). This file should be moved/renamed accordingly so it renders as the design doc root.
crates/cargo-gamma-attrs-impl/docs/DESIGN.md:4 - Repo convention is
crates/<crate>/docs/design/README.mdfor the crate design doc landing page (see AGENTS.md layout section). This file should be moved/renamed accordingly so it renders as the design doc root.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 78 out of 283 changed files in this pull request and generated no new comments.
Suppressed comments (4)
crates/cargo-gamma-lib/docs/DESIGN.md:4
- Repository guidelines require crate design docs to live at
docs/design/README.md(so GitHub renders it as the design landing page). This crate usesdocs/DESIGN.md, which deviates from the expected layout and will be harder to discover consistently.
crates/cargo-gamma-engine/docs/DESIGN.md:4 - Repository guidelines require crate design docs to live at
docs/design/README.md. This crate usesdocs/DESIGN.md, which deviates from the expected layout and will be harder to discover consistently.
crates/cargo-gamma-attrs/docs/DESIGN.md:4 - Repository guidelines require crate design docs to live at
docs/design/README.md. This crate usesdocs/DESIGN.md, which deviates from the expected layout and will be harder to discover consistently.
crates/cargo-gamma-attrs-impl/docs/DESIGN.md:4 - Repository guidelines require crate design docs to live at
docs/design/README.md. This crate usesdocs/DESIGN.md, which deviates from the expected layout and will be harder to discover consistently.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 77 out of 282 changed files in this pull request and generated no new comments.
Suppressed comments (1)
crates/cargo-each/Cargo.toml:19
cargo-eachis still a bin-only crate (no library target), but this PR removed the[package.metadata.ox-gen-readme] disable = trueopt-out that documents and enforces the exception to the repo’s auto-generated README convention. Restoring it keeps tooling aligned (and prevents future README regeneration attempts if a lib target is added later).
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 77 out of 282 changed files in this pull request and generated no new comments.
Suppressed comments (1)
crates/cargo-each/Cargo.toml:18
cargo-eachis a bin-only crate (nosrc/lib.rs), so it cannot participate in the repo’scargo doc2readme --libREADME generation/check flow. Restore the opt-out metadata (or add a real lib target specifically for rustdoc/README generation).
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 77 out of 282 changed files in this pull request and generated no new comments.
Suppressed comments (1)
crates/cargo-each/Cargo.toml:19
- This crate has no library target (only
src/main.rs), so it should remain opted out of doc2readme-based README generation/checks. Removing[package.metadata.ox-gen-readme] disable = truewill make README automation treat this like a lib crate and will conflict withjust readme/readme-check(which runcargo doc2readme --lib). Restore the opt-out (or add a real lib target if you intend generation).
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 77 out of 282 changed files in this pull request and generated no new comments.
Suppressed comments (4)
crates/cargo-gamma-lib/docs/DESIGN.md:5
- Design docs are expected at
crates/<crate>/docs/design/README.md(per AGENTS.md). This new design doc is atdocs/DESIGN.md, which diverges from the repository layout and makes it harder to find/render consistently. Consider moving/renaming it todocs/design/README.md.
crates/cargo-gamma-engine/docs/DESIGN.md:5 - Design docs are expected at
crates/<crate>/docs/design/README.md(per AGENTS.md). This new design doc is atdocs/DESIGN.md, which diverges from the repository layout and makes it harder to find/render consistently. Consider moving/renaming it todocs/design/README.md.
crates/cargo-gamma-attrs/docs/DESIGN.md:5 - Design docs are expected at
crates/<crate>/docs/design/README.md(per AGENTS.md). This new design doc is atdocs/DESIGN.md, which diverges from the repository layout and makes it harder to find/render consistently. Consider moving/renaming it todocs/design/README.md.
crates/cargo-gamma-attrs-impl/docs/DESIGN.md:5 - Design docs are expected at
crates/<crate>/docs/design/README.md(per AGENTS.md). This new design doc is atdocs/DESIGN.md, which diverges from the repository layout and makes it harder to find/render consistently. Consider moving/renaming it todocs/design/README.md.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 77 out of 282 changed files in this pull request and generated no new comments.
Suppressed comments (1)
crates/cargo-gamma-lib/docs/DESIGN.md:5
- AGENTS.md specifies that new crates must include a design doc at
docs/design/README.md. This crate instead addsdocs/DESIGN.md, which doesn’t follow the documented layout and makes it harder for contributors/tools to find the canonical design entry point consistently across crates.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 77 out of 282 changed files in this pull request and generated 1 comment.
Suppressed comments (4)
crates/cargo-gamma-engine/docs/DESIGN.md:5
- Repo guidelines require new crates to place design docs at
docs/design/README.md(see AGENTS.md layout). This file is atdocs/DESIGN.md, so it won’t follow the standard layout/rendering expectations.
crates/cargo-gamma-lib/docs/DESIGN.md:5 - Repo guidelines require new crates to place design docs at
docs/design/README.md(see AGENTS.md layout). This file is atdocs/DESIGN.mdinstead.
crates/cargo-gamma-attrs/docs/DESIGN.md:5 - Repo guidelines require new crates to place design docs at
docs/design/README.md(see AGENTS.md layout). This file is atdocs/DESIGN.md, not the standard location.
crates/cargo-gamma-attrs-impl/docs/DESIGN.md:5 - Repo guidelines require new crates to place design docs at
docs/design/README.md(see AGENTS.md layout). This file is atdocs/DESIGN.md, which doesn’t match that structure.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 77 out of 282 changed files in this pull request and generated no new comments.
Suppressed comments (1)
crates/cargo-gamma-lib/docs/DESIGN.md:5
- Design docs in this repo are expected at
crates/<crate>/docs/design/README.md(so they render as thedocs/design/landing page). This crate’s design doc is currently atdocs/DESIGN.md; please move/rename it (and apply the same layout to the other new cargo-gamma* crates’ design docs for consistency).
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 77 out of 282 changed files in this pull request and generated no new comments.
Suppressed comments (1)
crates/cargo-gamma-lib/docs/DESIGN.md:5
- New crates should land their design doc at
crates/<crate>/docs/design/README.md(so it renders as thedocs/design/landing page). This crate addsdocs/DESIGN.mdinstead, which diverges from the repository’s documented layout and will make design docs harder to find consistently across crates.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 77 out of 282 changed files in this pull request and generated no new comments.
Suppressed comments (1)
crates/cargo-gamma-lib/docs/DESIGN.md:5
- Repository guidelines expect new crate design docs at
crates/<crate>/docs/design/README.md(see AGENTS.md). This new design doc is added asdocs/DESIGN.md, which makes design-doc discovery inconsistent across crates.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 77 out of 282 changed files in this pull request and generated no new comments.
Suppressed comments (1)
crates/cargo-gamma-lib/docs/DESIGN.md:5
- Repository convention is to place crate design docs under
crates/<crate>/docs/design/README.md(so the folder renders as a landing page) rather thancrates/<crate>/docs/DESIGN.md(see AGENTS.md layout guidance). This file (and the other newdocs/DESIGN.mdfiles in the cargo-gamma crates) should be moved/renamed accordingly.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cd88f2d9-7bc6-448e-bcb7-469f4aaa0600
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 77 out of 282 changed files in this pull request and generated no new comments.
Suppressed comments (4)
crates/cargo-gamma-lib/docs/DESIGN.md:5
- Design docs in this repo are expected under
crates/<crate>/docs/design/README.md(AGENTS.md:41-47, 91-92). This crate usesdocs/DESIGN.mdinstead. Please move/rename todocs/design/README.mdso tooling and navigation stay consistent.
crates/cargo-gamma-engine/docs/DESIGN.md:5 - Design docs in this repo are expected under
crates/<crate>/docs/design/README.md(AGENTS.md:41-47, 91-92). This crate usesdocs/DESIGN.mdinstead. Please move/rename todocs/design/README.mdto match the repo’s design-doc layout.
crates/cargo-gamma-attrs/docs/DESIGN.md:5 - Design docs in this repo are expected under
crates/<crate>/docs/design/README.md(AGENTS.md:41-47, 91-92). This crate usesdocs/DESIGN.mdinstead. Please move/rename todocs/design/README.mdto match the standard layout.
crates/cargo-gamma-attrs-impl/docs/DESIGN.md:5 - Design docs in this repo are expected under
crates/<crate>/docs/design/README.md(AGENTS.md:41-47, 91-92). This crate usesdocs/DESIGN.mdinstead. Please move/rename todocs/design/README.mdto match the established convention.
No description provided.