Skip to content

chore(templated_uri): adopt latest ohno and release new version#379

Merged
martintmk merged 5 commits into
mainfrom
templated-uri-label
Apr 16, 2026
Merged

chore(templated_uri): adopt latest ohno and release new version#379
martintmk merged 5 commits into
mainfrom
templated-uri-label

Conversation

@martintmk

@martintmk martintmk commented Apr 16, 2026

Copy link
Copy Markdown
Member
  • bump ohno version
  • support for ErrorLabel

Copilot AI review requested due to automatic review settings April 16, 2026 07:43
@codecov

codecov Bot commented Apr 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (e75f236) to head (eb342eb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #379   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         224      224           
  Lines       16134    16135    +1     
=======================================
+ Hits        16134    16135    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates templated_uri to align with newer ohno error-labeling patterns and publishes a new crate version.

Changes:

  • Introduces ErrorLabel support for ValidationError (labels for invalid URI vs underlying http::Error).
  • Replaces ValidationError::caused_by(...) call sites with a labeled invalid_uri(...) helper.
  • Bumps templated_uri from 0.1.1 to 0.1.2 across workspace metadata (and updates docs.rs links).

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
crates/templated_uri/src/uri.rs Switches validation failures to use invalid_uri(...) for consistent labeling.
crates/templated_uri/src/error.rs Refactors ValidationError to carry an ErrorLabel and adds labeled From conversions + tests.
crates/templated_uri/src/base_uri/origin.rs Uses invalid_uri(...) for scheme/authority validation errors.
crates/templated_uri/src/base_uri/base_path.rs Uses invalid_uri(...) for base-path format validation errors.
crates/templated_uri/src/base_uri.rs Uses invalid_uri(...) when scheme/authority are missing.
crates/templated_uri/README.md Updates embedded docs.rs links to the new crate version.
crates/templated_uri/Cargo.toml Bumps crate version to 0.1.2.
crates/templated_uri/CHANGELOG.md Adds a 0.1.2 entry describing ErrorLabel support.
Cargo.toml Updates workspace dependency version for templated_uri to 0.1.2.
Cargo.lock Locks templated_uri to 0.1.2.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread crates/templated_uri/src/error.rs
Comment thread crates/templated_uri/src/error.rs Outdated
Comment thread crates/templated_uri/README.md
Comment thread crates/templated_uri/CHANGELOG.md
Copilot AI review requested due to automatic review settings April 16, 2026 08:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread crates/templated_uri/README.md
Comment thread crates/templated_uri/Cargo.toml
@martintmk martintmk enabled auto-merge (squash) April 16, 2026 09:15
@martintmk martintmk merged commit ee751bd into main Apr 16, 2026
27 checks passed
@martintmk martintmk deleted the templated-uri-label branch April 16, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants