chore: Update tool versions - #462
Merged
Merged
Conversation
Martin Taillefer (geeknoid)
enabled auto-merge (squash)
May 31, 2026 15:12
Martin Taillefer (geeknoid)
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates pinned tool/action versions and simplifies Rust toolchain update documentation/script behavior now that rust-toolchain.toml is no longer managed.
Changes:
- Bumps Rust, cargo tool,
just,sccache, Codecov, and CodeQL action pins. - Removes
rust-toolchain.tomlhandling fromscripts/update_rust_toolchain.ps1. - Updates README tooling guidance to describe constants-only Rust toolchain updates.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
scripts/update_rust_toolchain.ps1 |
Removes rust-toolchain.toml parameter, validation, parsing, and write logic. |
README.md |
Updates tooling documentation to match constants-only Rust toolchain updates. |
constants.env |
Bumps pinned Rust/tool versions used by CI and scripts. |
.github/workflows/publish-gh-release.yml |
Changes Rust setup action ref for release publishing. |
.github/workflows/main.yml |
Bumps Codecov action patch version. |
.github/workflows/codeql.yml |
Pins CodeQL init/analyze actions to a bundle tag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 307 307
Lines 23903 23903
=======================================
Hits 23903 23903 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Martin Taillefer (geeknoid)
force-pushed
the
tool_update
branch
from
May 31, 2026 15:46
86f44db to
9ae70a8
Compare
Martin Taillefer (geeknoid)
requested review from
martin-kolinek and
Ralf Biedert (ralfbiedert)
May 31, 2026 18:04
Sander Saares (sandersaares)
approved these changes
Jun 1, 2026
Ralf Biedert (ralfbiedert)
approved these changes
Jun 1, 2026
Kateřina Churanová (kate-shine)
added a commit
that referenced
this pull request
Aug 3, 2026
## Problem Pull requests from forks can never merge. They sit forever on: > Code scanning is waiting for results from CodeQL for the commits `<sha>` or `<sha>`. Current example: #624 (from `sandersaares/oxidizer`). **Root cause:** this repo uses CodeQL **default setup**, and default setup does not run for pull requests from forks — [that exclusion is documented behaviour](https://docs.github.com/en/code-security/concepts/code-scanning/setup-types), not a bug. The code-scanning merge-protection rule still expects a `CodeQL` result, so the check stays pending indefinitely and the PR is permanently blocked. Evidence gathered on this repo: | PR | Head repo | Fork? | CodeQL run | CodeQL check | |----|-----------|-------|-----------|--------------| | #621, #632, #568, #570-#573 | `microsoft/oxidizer` | no | yes | yes | | #624 | `sandersaares/oxidizer` | yes | none | none, blocked | | #622 | `kate-shine/oxidizer` | yes | none | none, blocked | ## Why advanced setup fixes it An advanced-setup workflow triggered by `pull_request` **does** run for fork PRs, and GitHub accepts its SARIF upload on public repositories even though the fork's `GITHUB_TOKEN` is read-only. Verified empirically against `prettier/prettier`, a public repo on advanced setup. On fork PR head `bf2849cee9d467aedf3fbd42a95201ea4393f855` (from `splincode/prettier`): - the only workflow runs are `pull_request` ones, including `.github/workflows/codeql.yml`; there is no `dynamic` (default setup) run at all; - yet `github-advanced-security` posted check `CodeQL` with conclusion `success`. ## History `.github/workflows/codeql.yml` already exists and is correct, but it has been in the `disabled_manually` state since **2026-01-22** and has not run since. It was introduced by #219 ("ci: Switch to advanced CodeQL mode"), whose stated goal was, verbatim, *"Once this is checked in, then we can tweak to improve permissions on forks"* — exactly the problem above. It ran 33 times, all successful, and roughly 4.5 hours after that PR merged, default setup was switched back on in the repository settings, which automatically disabled this workflow. No PR, issue or comment records a reason. Since then #232, #237, #462, #470, #484, #543, #563 and #574 have all been maintaining a workflow that never runs. ## Changes - Document why advanced setup is preferred, so this does not get silently reverted to default setup a second time. - Add the `merge_group` trigger. `main.yml` and `anvil-pr.yml` both have it and `codeql.yml` did not; without it the merge queue stalls on this workflow once it is required. - Bump `github/codeql-action` to `v4.37.3` (confirmed `"immutable": true` via the releases API, consistent with the existing tag-pinning rationale in the file). ## Required admin action, this PR alone is not sufficient Merging this changes nothing by itself, because the workflow is still disabled and GitHub will keep it disabled while default setup is on. A repository admin must, **in this order**: 1. Settings, Advanced Security, **disable CodeQL default setup**. 2. Re-enable this workflow: `gh api -X PUT repos/microsoft/oxidizer/actions/workflows/codeql.yml/enable`. Doing step 2 first does not work. ## Trade-off Fork PRs from **first-time contributors** will show CodeQL as `action_required` until a maintainer clicks "Approve and run". That is standard GitHub Actions fork policy and it also applies to every other `pull_request` workflow in this repo today. It is a single click, versus the current situation where fork PRs cannot merge at all. ## Draft Left as a draft until an admin confirms they will make the settings change, since merging without it is a no-op. Co-authored-by: Kateřina Churanová <katerina.churanova@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.