Add SHA-384 and SHA-512 hash algorithm support for PDB checksums#2366
Merged
Add SHA-384 and SHA-512 hash algorithm support for PDB checksums#2366
Conversation
Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for SHA-384 and SHA-512 algorithms in PDB
Add SHA-384 and SHA-512 hash algorithm support for PDB checksums
Feb 18, 2026
brianrob
reviewed
Feb 18, 2026
| { | ||
| _hashAlgorithm = System.Security.Cryptography.SHA256.Create(); | ||
| } | ||
| else if (srcFormat.Header.algorithmId == guidSHA384) |
Member
There was a problem hiding this comment.
@tmat do these new GUIDs apply to native PDBs (Windows) or just portable PDBs?
Member
There was a problem hiding this comment.
Great. Thanks. We'll get this merged.
leculver
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDB files can specify document checksums using SHA-384 or SHA-512 per the Portable PDB spec. TraceEvent currently only recognizes MD5, SHA-1, and SHA-256.
Changes
Added GUID constants for the new algorithms:
d99cfeb1-8c43-444a-8a6c-b61269d2a0bfef2d1afc-6550-46d6-b14b-d70afe9a5566Updated hash algorithm instantiation in three locations:
PortableSymbolModule.cs- Portable PDB document handlingNativeSymbolModule.cs- Native PDB managed source checksum handlingSymbolReader.cs-ChecksumAlgorithmproperty type checksAll changes follow the existing pattern used for SHA-1 and SHA-256:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.