Remove formatting for scripting service#534
Merged
mmcfarland merged 4 commits intomainfrom Mar 31, 2025
Merged
Conversation
The scripting service recently was changed to include sqlparse formatting prior to returning the generated sql. However, this formatting doesn't produce well formatted results in many cases. Instead, the sql templates that were producing the original poorly formatted results were changed to be formatted nicely, as all other scripting output is. The formatting is still an issue in generally, and that is being tracked.
mmcfarland
force-pushed
the
user/mjm/scripting-svc-formats
branch
from
cfe3eaf to
2879a36
Compare
mmcfarland
force-pushed
the
user/mjm/scripting-svc-formats
branch
from
9be3b62 to
9a58e20
Compare
lossyrob
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scripting service recently was changed to include sqlparse formatting prior to returning the generated sql. However, this formatting doesn't produce well formatted results in many cases. Instead, the formatter calls were removed, and the sql templates that were producing the original poorly formatted results were changed to be formatted nicely, as all other scripting templates are.
The formatting is still an issue in generally, and that is being tracked here https://github.com/microsoft/pgtoolsservice/issues/533