Implement Schema Designer module - visualization only for now#538
Merged
Implement Schema Designer module - visualization only for now#538
Conversation
added 6 commits
April 3, 2025 15:42
lossyrob
requested changes
Apr 9, 2025
Contributor
lossyrob
left a comment
lossyrob
left a comment
There was a problem hiding this comment.
Review comments on service-level and connection management items.
I'll review the SchemaEditorSession logic next.
Another general ask - we should have some unit tests around this to test and avoid regressions in the future. I recommend using tests_v2 to model sending messages directly via the server client wrapper; there are examples in the other service test code e.g. objectexplorer.
added 4 commits
April 10, 2025 00:16
lossyrob
requested changes
Apr 10, 2025
Contributor
lossyrob
left a comment
lossyrob
left a comment
There was a problem hiding this comment.
Looking good! More review comments, discussion around how to approach responses vs notifications in session management.
added 4 commits
April 14, 2025 23:06
- Move connection management and handling to extension - Use REQ/RSP/NOTIF model for communication - General cleanup from review comments - TODO: fix DB schema retrieval, still some issues
Contributor
|
@mmihir can you give the PR a descriptive title, this will be the commit message once it's squash merged in. |
lossyrob
requested changes
Apr 15, 2025
Contributor
lossyrob
left a comment
lossyrob
left a comment
There was a problem hiding this comment.
Few things, and a question about what we want to support now vs later.
mmihir
changed the title
lossyrob
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the following endpoints:
schemaDesigner/createSessionschemaDesigner/closeSessionschemaDesigner/getSchemaModelImplements a session based interface to retrieve the full schema of a database, and in the future, support modifications as well.