fix(connection): register protocol callback only after successful send - #3167
Merged
Skn0tt merged 2 commits intoAug 5, 2026
Merged
Conversation
Fixes one of the two cases of microsoft#3165 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 358aa828-ed44-482a-8a83-91d435d25b38
The sync subprocess test already covers the user-visible warning. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 358aa828-ed44-482a-8a83-91d435d25b38
dcrousso
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
transport.sendfails (e.g. non-JSON-serializable params), we used to leave aProtocolCallbacksitting inconnection._callbacks.cleanup()laterset_exceptions on it, and nobody awaits it →Future exception was never retrieved.Fix is to register the callback only after a successful send.
Fixes one of the two cases of #3165