fix: allow trace in showBrowser mode #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trace was disabled in microsoft#319 to solve microsoft/playwright#21993. Since then, two things happened: - we do not clear output dir anymore; - `tracesDir` is ignored when launching a reused browser over `connect()`. Therefore, we do not need to disable tracing anymore, so might as well keep it.
Skn0tt
approved these changes
Oct 22, 2024
Merged
pavelfeldman
added a commit
to pavelfeldman/playwright-vscode
that referenced
this pull request
Nov 14, 2024
This reverts commit 002fc12.
pavelfeldman
added a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trace was disabled in #319 to solve microsoft/playwright#21993.
Since then, two things happened:
tracesDiris ignored when launching a reused browser overconnect().Therefore, we do not need to disable tracing anymore, so might as well keep it.
Fixes microsoft/playwright#33155.