feat: steps/action filter#39334
Closed
EmanueleMinotto wants to merge 3 commits intomicrosoft:mainfrom
Closed
Conversation
- Introduced a search field to filter test steps by title in the Test Steps section. - Implemented logic to display only matching steps and their parent steps. - Updated tests to verify the filtering functionality works as expected.
- Introduced a search field in the Actions tab to filter actions by title. - Implemented logic to display only matching actions and their parent actions. - Added tests to verify the filtering functionality works as expected.
Author
|
@microsoft-github-policy-service agree |
Signed-off-by: Emanuele Minotto <minottoemanuele@gmail.com>
Member
|
The feature is nice, but the generated code is not great and is hard to review. |
Author
|
@pavelfeldman since the feature is nice, can I retry with a different code? should i split the feature into two smaller PRs (html reporter and trace viewer)? if you have any suggestion for a retry, I'll be happy to follow the suggestions and contribute to the project :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should close partially #36477
I've added the filter input to both html report and trace viewer.
HTML Reporter
Trace Viewer
Hopefully I didn't miss any of the contributing points, sorry if I missed something.