fix(cli): fix list command not showing sessions when workspaceDir is undefined - #40039
Merged
Yury Semikhatsky (yury-s) merged 2 commits intoApr 3, 2026
Merged
Conversation
…undefined When the cwd has no .playwright directory, workspaceDir is undefined and the registry key is workspaceDirHash. The list command was comparing workspace keys against workspaceDir only, so sessions were never shown in this case.
…undefined When the cwd has no .playwright directory, workspaceDir is undefined and the registry stores sessions under workspaceDirHash as the key. The list command was comparing workspace keys against workspaceDir only, so sessions were never shown in this case. Extract clientKey() helper to deduplicate the workspaceDir || workspaceDirHash fallback pattern used across registry.ts and program.ts.
Pavel Feldman (pavelfeldman)
approved these changes
Apr 3, 2026
Yury Semikhatsky (yury-s)
merged commit Apr 3, 2026
c1764b8
into
microsoft:main
9 of 10 checks passed
Contributor
Test results for "MCP"1 failed 6382 passed, 377 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.playwrightdirectory,workspaceDiris undefined and the registry stores sessions underworkspaceDirHashas the keylistcommand was comparing workspace keys againstclientInfo.workspaceDironly, soworkspaceDirHash !== undefinedwas alwaystrueand all sessions were skippedclientInfo.workspaceDir || clientInfo.workspaceDirHash(same pattern asRegistry.entries()) for the comparison