fix(step): fixed truncating error stack traces with Promise.all#40319
Closed
ChernyshovDmitriy wants to merge 1 commit intomicrosoft:mainfrom
Closed
fix(step): fixed truncating error stack traces with Promise.all#40319ChernyshovDmitriy wants to merge 1 commit intomicrosoft:mainfrom
ChernyshovDmitriy wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
Collaborator
|
Thank you for the PR! Closing in favor of #40331. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40141
Summary
Fix that was described by @pavelfeldman #40141 (comment) to save all stack trace of errors, when using
Promise.allinside POMFix by conditionally calls
_onUserStepBeginand_onUserStepEndAdd test for that fix