fix(test runner): proper async stack inside chained steps#40331
Merged
dgozman merged 1 commit intomicrosoft:mainfrom Apr 21, 2026
Merged
fix(test runner): proper async stack inside chained steps#40331dgozman merged 1 commit intomicrosoft:mainfrom
dgozman merged 1 commit intomicrosoft:mainfrom
Conversation
Recent changes have introduced more async hops inside the `test.step()` implementation that revealed an issue with `raceAgainstDeadline` that truncated stacks at the first async hop due to missing `await`.
Contributor
Test results for "tests 1"4 flaky39252 passed, 847 skipped Merge workflow run. |
Contributor
Test results for "MCP"3 failed 6520 passed, 913 skipped Merge workflow run. |
pavelfeldman
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent changes have introduced more async hops inside the
test.step()implementation that revealed an issue withraceAgainstDeadlinethat truncated stacks at the first async hop due to missingawait.Fixes #40141.