Skip to content

feat(dashboard): cancel CLI annotate on client disconnect#40344

Closed
pavelfeldman wants to merge 1 commit into
microsoft:mainfrom
pavelfeldman:long_annotate
Closed

feat(dashboard): cancel CLI annotate on client disconnect#40344
pavelfeldman wants to merge 1 commit into
microsoft:mainfrom
pavelfeldman:long_annotate

Conversation

@pavelfeldman
Copy link
Copy Markdown
Member

@pavelfeldman pavelfeldman commented Apr 21, 2026 •
edited
Loading

Summary

  • Migrate BrowserTracker to the mirrored BrowserContext lifecycle events — drops the per-page listener bookkeeping.
  • Emit cancelAnnotate when the last --annotate client socket closes; dashboard disengages annotate mode and subsequent submits save as a download.
  • Lift the "submit to CLI vs save to disk" decision out of annotations.tsx into dashboard.tsx; extract saveAnnotationAsDownload.
  • cliAnnotate now survives switching between dashboard modes until submit/cancel.
  • Remove the superseded pick CLI command; the annotate workflow replaces it.

@github-actions

This comment has been minimized.

Sign in to view
@microsoft microsoft deleted a comment from github-actions Bot Apr 21, 2026
@pavelfeldman
feat(dashboard): cancel CLI annotate on client disconnect
219b96e 
Migrate BrowserTracker to the mirrored BrowserContext lifecycle events.
When the last `--annotate` client socket closes, the server emits
`cancelAnnotate` so the dashboard disengages annotate mode and future
submissions fall back to saving as a download. Remove the superseded
`pick` CLI command in favor of the `show --annotate` workflow.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

Test results for "tests 1"

5 flaky ⚠️ [chromium-library] › library/video.spec.ts:275 › screencast › should capture navigation `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/video.spec.ts:275 › screencast › should capture navigation `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104 › should work with strict CSP policy `@firefox-ubuntu-22.04-node20`

41307 passed, 847 skipped

Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

Test results for "MCP"

7 failed
❌ [chrome] › mcp/dashboard.spec.ts:261 › should switch screencast to -s session on show --annotate @mcp-windows-latest
❌ [chromium] › mcp/dashboard.spec.ts:261 › should switch screencast to -s session on show --annotate @mcp-windows-latest
❌ [firefox] › mcp/dashboard.spec.ts:261 › should switch screencast to -s session on show --annotate @mcp-ubuntu-latest
❌ [webkit] › mcp/dashboard.spec.ts:261 › should switch screencast to -s session on show --annotate @mcp-ubuntu-latest
❌ [firefox] › mcp/dashboard.spec.ts:261 › should switch screencast to -s session on show --annotate @mcp-windows-latest
❌ [webkit] › mcp/dashboard.spec.ts:261 › should switch screencast to -s session on show --annotate @mcp-windows-latest
❌ [msedge] › mcp/dashboard.spec.ts:261 › should switch screencast to -s session on show --annotate @mcp-windows-latest

6555 passed, 913 skipped

Merge workflow run.

This was referenced Apr 22, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yury-s yury-s yury-s approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pavelfeldman @yury-s