feat(dashboard): cancel CLI annotate on client disconnect#40347
Merged
Conversation
Migrate BrowserTracker to the mirrored BrowserContext lifecycle events. When the last `--annotate` client socket closes, the server emits `cancelAnnotate` so the dashboard disengages annotate mode and future submissions fall back to saving as a download. Remove the superseded `pick` CLI command in favor of the `show --annotate` workflow.
Fixes a race in 'should switch screencast to -s session on show --annotate' where dashboard.evaluate() in sampleCenter() could be interrupted by the in-flight navigation triggered by innerOpenDashboardApp's page.goto. Awaiting #display visibility serializes against that navigation.
Skn0tt
changed the title
dgozman
approved these changes
Apr 22, 2026
Contributor
Test results for "MCP"7 failed 6555 passed, 913 skipped Merge workflow run. |
Contributor
Test results for "tests 1"8 flaky41304 passed, 847 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(#40344 with test fix)