fix(test-runner): cap webServer availability probe timeout to 1s#40433
Closed
devareddy05 wants to merge 1 commit intomicrosoft:mainfrom
Closed
fix(test-runner): cap webServer availability probe timeout to 1s#40433devareddy05 wants to merge 1 commit intomicrosoft:mainfrom
devareddy05 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Author
@microsoft-github-policy-service agree |
Member
|
closed in favour of #40458 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cap each pre-launch
webServeravailability probe at 1s so we no longer hang on the OS-default TCP connect timeout (~2 min) when SYNs are silently dropped — notably on WSL mirrored networking where Windows Defender Firewall drops packets to closed loopback ports.isPortUsed(): explicitsocket.setTimeout(), treattimeoutlike a connection error.httpStatusCode(): wrap the request with a timer that callscancel(). A request-levelsetTimeoutis not enough — Happy Eyeballs only assigns a socket to the request once one address connects, so until then there is no socket for the request-level timeout to attach to.Fixes #40430