feat(test runner): use happy eyeballs in webServer port check#40458
Merged
Skn0tt merged 1 commit intomicrosoft:mainfrom Apr 28, 2026
Merged
feat(test runner): use happy eyeballs in webServer port check#40458Skn0tt merged 1 commit intomicrosoft:mainfrom
Skn0tt merged 1 commit intomicrosoft:mainfrom
Conversation
isPortUsed now delegates to createSocket from @utils/happyEyeballs instead of probing 127.0.0.1 then ::1 sequentially. Also re-export happyEyeballs from @utils/index so the cross-package @utils/* -> coreBundle.utils.* build rewrite resolves createSocket for callers outside playwright-core.
Contributor
Test results for "tests 1"13 flaky41466 passed, 847 skipped Merge workflow run. |
Contributor
Test results for "MCP"6808 passed, 927 skipped Merge workflow run. |
dgozman
approved these changes
Apr 28, 2026
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40430