Skip to content

feat(test): support more video recording modes#41085

Merged
yury-s merged 1 commit into
microsoft:mainfrom
yury-s:fix-40936
Jun 2, 2026
Merged

feat(test): support more video recording modes#41085
yury-s merged 1 commit into
microsoft:mainfrom
yury-s:fix-40936

Conversation

@yury-s
Copy link
Copy Markdown
Member

@yury-s yury-s commented Jun 1, 2026

Summary

  • Adds on-all-retries, retain-on-first-failure, retain-on-failure-and-retries and retain-all-failures to the video test option, bringing it to parity with trace.

Fixes #40936

Brings the `video` test option to parity with `trace` by adding
`on-all-retries`, `retain-on-first-failure`, `retain-on-failure-and-retries`
and `retain-all-failures` modes.

Fixes: microsoft#40936
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

Test results for "MCP"

7230 passed, 1103 skipped


Merge workflow run.

@yury-s yury-s merged commit 2ff4137 into microsoft:main Jun 2, 2026
45 checks passed
@yury-s yury-s deleted the fix-40936 branch June 2, 2026 00:12
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

Test results for "tests 1"

8 flaky ⚠️ [chromium-page] › page/page-request-continue.spec.ts:756 › propagate headers cross origin redirect after interception `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:682 › screencast › should capture full viewport on hidpi `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/video.spec.ts:719 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node22`
⚠️ [chromium-page] › page/page-request-continue.spec.ts:756 › propagate headers cross origin redirect after interception `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/har-websocket.spec.ts:170 › should record websocket connection failure `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-page] › page/page-network-request.spec.ts:288 › should parse the data if content-type is application/x-www-form-urlencoded `@webkit-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:189 › should show snapshots for steps `@windows-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:816 › should update state on subsequent run `@windows-latest-node20`

39475 passed, 775 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: add 'retain-if-last-attempt-fails' to testOptions.video

2 participants