Skip to content

chore(trace): remove retain-all-failures trace and video mode#41123

Merged
yury-s merged 1 commit into
microsoft:mainfrom
yury-s:revert-retain-all-failures
Jun 3, 2026
Merged

chore(trace): remove retain-all-failures trace and video mode#41123
yury-s merged 1 commit into
microsoft:mainfrom
yury-s:revert-retain-all-failures

Conversation

@yury-s
Copy link
Copy Markdown
Member

@yury-s yury-s commented Jun 3, 2026

Summary

  • Remove the retain-all-failures mode from both trace and video options.
  • On a closer look it behaves the same as retain-on-failure; we'll clarify the distinction in the docs separately.

Reverts retain-all-failures added in #40838 (trace) and #41085 (video).

Reverts #40832

The new mode behaves the same as retain-on-failure for the eventual
outcome; the distinction will be clarified in the docs separately.

Reverts retain-all-failures added in microsoft#40838 (trace) and microsoft#41085 (video).

Reverts: microsoft#40832
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

Test results for "MCP"

7230 passed, 1103 skipped


Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

Test results for "tests 1"

1 failed
❌ [webkit-library] › library/client-certificates.spec.ts:346 › browser › should not intercept TLS for origins without a client certificate @webkit-ubuntu-22.04-node20

1 flaky ⚠️ [firefox-library] › library/har-websocket.spec.ts:313 › should record websocket connection failure `@firefox-ubuntu-22.04-node20`

39531 passed, 771 skipped


Merge workflow run.

@yury-s yury-s merged commit 1660114 into microsoft:main Jun 3, 2026
45 of 46 checks passed
@yury-s yury-s deleted the revert-retain-all-failures branch June 3, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants