feat(locator): introduce Locator.waitForFunction()#41380
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yury-s
approved these changes
Jun 19, 2026
dgozman
force-pushed
the
locator-wait-for-function
branch
from
June 23, 2026 09:56
1d8c278 to
2dd6de9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Waits until a predicate, called with the matching element as its first argument, returns a truthy value. The locator is re-resolved on every poll, so it tolerates the element being re-rendered. Useful for synchronization inside helpers without asserting. Drive-by: fixes wrong type overrides for Locator. Closes microsoft#41317
dgozman
force-pushed
the
locator-wait-for-function
branch
from
June 23, 2026 12:02
2dd6de9 to
9c5f7e3
Compare
Contributor
Test results for "MCP"7380 passed, 1122 skipped Merge workflow run. |
Contributor
Test results for "tests 1"2 failed 3 flaky48999 passed, 1142 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Locator.waitForFunction(pageFunction, arg?, options?)— waits until the predicate, called with the matching element as its first argument, returns a truthy value.Frame.waitForFunctionmachinery with an optionalselector; no new protocol method.Drive-by: fixes wrong type overrides for
Locator.References #41317