You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Do not merge the locale-derived Accept-Language header into Firefox extra HTTP headers — the browser-side language override already produces the header, and the extra-header mechanism was clobbering an Accept-Language explicitly set on a fetch/XHR request.
Add a test that an explicit Accept-Language on a fetch is preserved and that the locale-derived one is still sent when the request does not specify it. Marked fixme on WebKit until the corresponding browser fix rolls.
References #23732 (fixes the Firefox part; WebKit needs a separate fix).
3 flaky⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-node24` ⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20` ⚠️ [playwright-test] › ui-mode-trace.spec.ts:388 › should reveal errors in the sourcetab `@windows-latest-node22`
2 failed
❌ [webkit] › mcp/annotate.spec.ts:110 › should abort annotation when last screenshot is removed @mcp-macos-latest-webkit
❌ [webkit] › mcp/annotate.spec.ts:173 › user-initiated annotate downloads zip with feedback.md @mcp-macos-latest-webkit
Hi, I'm the Playwright bot and I took a first look at the CI failures.
🟢 The failures are pre-existing flakes — this PR is clear
The only two failures are mcp/annotate.spec.ts on WebKit, and this PR touches Firefox ffBrowser.ts plus a locale test — nothing in the MCP annotate path. Both tests flip verdict across runs on SHAs this PR can't be responsible for.
Details
Pre-existing flake / infra
[webkit] › mcp/annotate.spec.ts:110 › should abort annotation when last screenshot is removed — flake. Across the test-results DB this WebKit test failed 4 of 316 runs and passed the other 312, including a failure on push sha 97a80eb8 and on unrelated PR chore(recorder): move signals from the action onto the action context #41755 — none of them this PR. It also flakes on chromium/chrome/firefox, so it isn't engine-specific.
The PR's diff is confined to the Firefox Accept-Language header logic and browsercontext-locale.spec.ts; the MCP annotate flow exercises neither. The tests 1 report had only 3 flaky (no failures).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept-Languageheader into Firefox extra HTTP headers — the browser-side language override already produces the header, and the extra-header mechanism was clobbering anAccept-Languageexplicitly set on afetch/XHR request.Accept-Languageon a fetch is preserved and that the locale-derived one is still sent when the request does not specify it. Marked fixme on WebKit until the corresponding browser fix rolls.References #23732 (fixes the Firefox part; WebKit needs a separate fix).