test(websocket): cover setExtraHTTPHeaders and locale on the handshake request - #42037
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…shake request `Network.setExtraHTTPHeaders` and an emulated `locale` now reach the `WebSocket` handshake request, but nothing exercised either from the page or from inside a `Worker` Chromium: - <https://chromium-review.googlesource.com/c/chromium/src/+/7950740> (Network.setExtraHTTPHeaders should affect WebSocket handshake requests) - <https://chromium-review.googlesource.com/c/chromium/src/+/8000530> (Network.setExtraHTTPHeaders should affect WebSocket requests in a Worker) WebKit: - <WebKit/WebKit#67097> (Web Inspector: Network.setExtraHTTPHeaders does not affect WebSocket) Chrome Stable and Edge Stable are both still on 150, which predates that Chromium work, so widen the existing guard to `browserMajorVersion < 151` and reuse it on the new cases Firefox drops the browsing context association when it opens the handshake channel, so the `Worker` cases stay `it.fixme` there until the bundled Firefox picks up <https://phabricator.services.mozilla.com/D310690>
4bb031a to
7c2ffa0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "MCP"1 failed 8049 passed, 1284 skipped Merge workflow run. |
🟢 CI is clear — the one failure is a pre-existing Firefox-on-Windows flakeHi, I'm the Playwright bot and I took a first look at the CI failures here. The single failure — DetailsOverall: 1 failed, 8049 passed, 1284 skipped. The one failure is a known Firefox/Windows flake; nothing here looks caused by the PR. Pre-existing flake / infra
Triaged by the Playwright bot - agent run |
Test results for "tests 1"1 failed 3 flaky51217 passed, 1190 skipped Merge workflow run. |
🟢 CI is clear — the one failure is a pre-existing cross-PR flakeHi, I'm the Playwright bot and I took another look at the CI failures here. The single failure — DetailsOverall: 1 failed, 51217 passed, 1190 skipped, plus 3 within-run flakies a retry rescued. This PR changes no product code — only test files Pre-existing flake / infra
Triaged by the Playwright bot Triaged by the Playwright bot - agent run |
Network.setExtraHTTPHeadersand an emulatedlocalenow reach theWebSockethandshake request, but nothing exercised either from the page or from inside aWorkerChromium:
WebKit:
Network.setExtraHTTPHeadersdoes not affectWebSocketWebKit/WebKit#67097 (Web Inspector: Network.setExtraHTTPHeaders does not affect WebSocket)Chrome Stable and Edge Stable are both still on 150, which predates that Chromium work, so widen the existing guard to
browserMajorVersion < 151and reuse it on the new casesFirefox drops the browsing context association when it opens the handshake channel, so the
Workercases stayit.fixmethere until the bundled Firefox picks up https://phabricator.services.mozilla.com/D310690fixes #13919
fixes #28948