test: unflake har-websocket timing assertions - #42126
Merged
Merged
Conversation
- tolerate 100ms clock skew between browser-reported wall times and Date.now() (flaked on Windows bots only, where the browser clock and the Node clock can disagree at the millisecond level) - allow the recorded websocket duration to slightly under-run the nominal setTimeout delays - report zero HAR entry duration instead of -1 when all websocket frames share a single coarse-clock timestamp
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dcrousso
approved these changes
Aug 4, 2026
| expect(wsEntry.time).toBeGreaterThanOrEqual(delayMs * (incomingCount + outgoingCount)); | ||
| // setTimeout may fire marginally early and browser-reported timestamps are | ||
| // coarse on some platforms, so the measured span can under-run the nominal delays. | ||
| expect(wsEntry.time).toBeGreaterThanOrEqual(delayMs * (incomingCount + outgoingCount) - clockSkewMs); |
Contributor
There was a problem hiding this comment.
i think we may need to just drop this check as it has failed with
883mshttps://github.com/microsoft/playwright/actions/runs/29845176099/job/88683834325607mshttps://github.com/microsoft/playwright/actions/runs/29329966412/job/870752848411061mshttps://github.com/microsoft/playwright/actions/runs/29314574075/job/87025605804
so the 100ms is not good enough
Contributor
|
Hi, I'm the Playwright bot and I took a first look at the CI failures here. 🟢 CI is clear — the failures don't come from this PRThis is a test-only change to the HAR websocket timing assertions ( DetailsOverall: the diff only changes HAR websocket duration reporting and its test. The Pre-existing flake / infra
I'm a first pass, not the final word — but I'd merge on the CI signal here. Triaged by the Playwright bot - agent run |
Contributor
Test results for "tests 1"8 flaky51191 passed, 1188 skipped Merge workflow run. |
Contributor
Test results for "MCP"8050 passed, 1284 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Date.now()— flaked exclusively on Windows bots, where the browser's monotonic-based wall-time estimate and Node's clock disagree at the millisecond levelsetTimeoutdelays