Skip to content

chore: cleanup more ct remnants - #42200

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
dgozman:chore-cleanup-after-ct
Aug 11, 2026
Merged

chore: cleanup more ct remnants#42200
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
dgozman:chore-cleanup-after-ct

Conversation

@dgozman

Copy link
Copy Markdown
Collaborator

Follow up to #42168.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [chrome] › mcp/annotate.spec.ts:386 › should cancel browser_annotate when the MCP request is aborted @mcp-windows-latest-chrome
❌ [chrome] › mcp/annotate.spec.ts:417 › should cancel browser_annotate when the MCP client disconnects @mcp-windows-latest-chrome

8087 passed, 1284 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures here.

🟢 Both failures are pre-existing flakes — this PR is clear

The two mcp/annotate.spec.ts cancellation tests flip verdict across many unrelated SHAs and PRs, and this PR doesn't touch the MCP annotate flow at all — it only cleans up test-runner plugin/dependency-tracking code.

Details

This PR removes leftover component-testing plumbing: the populateDependencies/clearCache/begin/end plugin hooks, the externalDependencies map in compilationCache.ts, and the populateDependenciesOnList test-server option. None of that is exercised by the MCP annotate cancellation flow.

Pre-existing flake / infra

Both are cancellation/disconnect tests — inherently timing-sensitive — and neither was rescued on retry in the runs where they flaked, consistent with a genuine intermittent race rather than a code regression.

Triaged by the Playwright bot - agent run

@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit 10c9602 into microsoft:main Aug 11, 2026
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants