fix(aria): annotate aria-hidden elements in AI snapshots - #42268
Open
triemerge wants to merge 1 commit into
Open
fix(aria): annotate aria-hidden elements in AI snapshots#42268triemerge wants to merge 1 commit into
triemerge wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The AI-mode snapshot (
mode: "ai") intentionally includesaria-hiddenelements because they are visually visible, but nothing distinguishes them from ARIA-visible content. When a test fails anderror-context.mdis generated, agents (and humans) see content thatgetByRoleandariaSnapshot()will never find, with no indication why.This adds an
[aria-hidden]annotation following the same bracket pattern as[checked],[disabled],[expanded]etc. Elements included only through visual visibility (not ARIA visibility) now render with[aria-hidden]in the key. Default-mode snapshots are completely unaffected since they exclude these elements entirely.Fixes #42223