fix(client-certificates): reestablish a way to explicitly send no client certificate for an origin - #42547
Open
Florian Schwalm (egfx-notifications) wants to merge 2 commits into
Open
Conversation
…empty client certificates list
…rage sendNone combined with cert/key/passphrase/pfx, or mixed with a real certificate on the same origin, now throws instead of silently resolving. Adds test coverage for sendNone across fetch, browser and persistentContext, and clarifies the docs.
|
Florian Schwalm (@egfx-notifications) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the ability to explicitly send no client certificate for an origin, fixing a regression from #41113 (first released in v1.61.0).
Details
sendNoneoption to theclientCertificatestest option so we can explicitly request sending no certificate to a server rather than relying on the previous implicit "clientCertificates set, but origin not mentioned in configured origins means intercept and send no certificate"Fixes #42546