Skip to content

remove time machine headings and fix keyboard controls - #11443

Merged
riknoll merged 2 commits into
masterfrom
dev/riknoll/microbit-tree-keyboard
Jun 30, 2026
Merged

remove time machine headings and fix keyboard controls#11443
riknoll merged 2 commits into
masterfrom
dev/riknoll/microbit-tree-keyboard

Conversation

@riknoll

@riknoll riknoll commented Jun 30, 2026

Copy link
Copy Markdown
Member

fixes microsoft/pxt-microbit#6863

removes the unnecessary h3 tags on the time machine dialog and fixes keyboard controls for the react-common tree component.

here's the new keyboard controls:

  • pressing right on a collapsed subtree causes it to expand without changing focus
  • pressing right on an expanded subtree causes focus to move to the first item
  • pressing left on an expanded subtree causes it to collapse without moving focus
  • pressing left on a tree item or collapsed subtree will focus the parent treeitem if it exists
  • up, down, home, and end all navigate the visible items like you'd think

also fixes the roles for the treeitems and the groups, simplifies the exported react elements, and makes it so that only the selected tree item serves as a tab stop in the page tab order

@riknoll
riknoll requested a review from a team June 30, 2026 21:34
@riknoll
riknoll added this pull request to the merge queue Jun 30, 2026
Merged via the queue into master with commit 8c5a768 Jun 30, 2026
20 checks passed
@riknoll
riknoll deleted the dev/riknoll/microbit-tree-keyboard branch June 30, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary and Incorrect Heading Defined for Banner Section: A11y_Microsoft MakeCode_Settings_Version History_Info and Relationships.

2 participants