fix rendering of diffs for files that exceed our max diff size#11497
Open
riknoll wants to merge 1 commit into
Open
fix rendering of diffs for files that exceed our max diff size#11497riknoll wants to merge 1 commit into
riknoll wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reported on the forum here:
https://forum.makecode.com/t/help-github-project-opens-to-a-white-screen-but-the-extension-imports-correctly/45031/3
if a diff in a github repo is bigger than our maximum allowed diff size,
computeFormattedDiff()will throw an exception sincecompute()returns nullthe places where
computeFormattedDiff()is called all had handling for if it returns null/undefined, so clearly i must have broken this at some point in all the version history refactors. this PR fixes it by making sure we propagate any null return values up