Move skillmap projects to the editor workspace#8290
Merged
Conversation
shakao
reviewed
Jul 13, 2021
shakao
reviewed
Jul 13, 2021
| { label: lf("RESTART"), onClick: () => { | ||
| tickEvent("skillmap.activity.restart", { path: mapId, activity: activity!.activityId }); | ||
| dispatchRestartActivity(mapId, activity!.activityId); | ||
| if (showCodeCarryoverModal) dispatchShowCarryoverModal(mapId, activity!.activityId); |
Contributor
There was a problem hiding this comment.
is it weird to have two subsequent modals like this? do the modals look different enough that kids won't just rapidly click on the rightmost button twice in a row? (probably a thing to discuss/fix in a later pr)
Member
Author
There was a problem hiding this comment.
I think we should maybe take a look at it in a design meeting; could be confusing.
shakao
reviewed
Jul 13, 2021
shakao
reviewed
Jul 13, 2021
shakao
reviewed
Jul 13, 2021
jwunderl
approved these changes
Jul 13, 2021
Contributor
|
hmm the completion modal/confetti autodisplay doesn't seem to be happening in the builds here |
shakao
approved these changes
Jul 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving all of the skillmap projects from outside the editor iframe to inside! List of changes includes:
Here's a test upload:
Note: If you open this editor/skillmap upload, all of your skillmap tutorial projects will suddenly show up in the beta/released editor. The code to filter skillmap projects out of "My Projects" is part of this PR
TODO: