don't disable cloud sync for skillmap#11008
Merged
Merged
Conversation
Collaborator
|
Now I question the popularity of skillmap |
Collaborator
|
We should hotfix this right away. |
jwunderl
approved these changes
Dec 11, 2025
Member
There was a problem hiding this comment.
it looks like that enableAuth(false) path was hit prior to that pr, that pr bumped it up a lil earlier but the original intention of the check was skipping for skillmap? https://github.com/microsoft/pxt/pull/7934/changes
or is there something else in between I'm missing there, like auth being enabled until workspace is set up then disabled after? either way change seems fine now just curious
Member
Author
Member
Author
|
the workspace was changed here #8290 |
riknoll
added a commit
that referenced
this pull request
Dec 11, 2025
riknoll
added a commit
that referenced
this pull request
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this was regressed by #9546. I believe that change went out in arcade in march, so it's been broken for most of this year.
fixes cloud syncing of skillmap projects.