Fix settings in iframe editor embed#9546
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix microsoft/pxt-microbit#5209
Here's a forked build from the one in that issue pointing at a build with this change: https://wyttlr.csb.app/ (there will be an overlay button in the bottom right to see the code of the sandbox)
microbit build: https://makecode.microbit.org/app/4e857c4bdf435b028015828dbd8d4af76e3d2c48-72860080ee
arcade build: https://arcade.makecode.com/app/15ee7b4f6abf540a00d30fa275c70925a5bdceeb-35abd09842--skillmap
I believe the change in
pxtlib/auth.tsshould technically be enough to cover this regression (+ a673adf to make it so language / high contrast persist through refreshes), but I ran into some other things while trying to figure out why it wasn't working so poked around a bit (e.g. we have some logic to cut auth from embed scenarios, but it was running after some initialization code that was leaving around some half initialized login state).